[Bug] Robust code for profiler server (#1221)

* robust code for profiler

* robust code

visualdl/component/profiler/profiler_data.py

@@ -131,6 +131,8 @@ class ProfilerData:
         return views
 
     def get_device_infos(self):
+        if not self.overview_parser:
+            return
         if not self.overview_parser.has_device:
             device_type = 'CPU'
             return {
@@ -219,6 +221,8 @@ class ProfilerData:
         '''
         Get total cpu and gpu statistics for model perspective of each profiler step.
         '''
+        if not self.overview_parser:
+            return
         data = OrderedDict()
         data['column_name'] = [
             "name", "calls", "total_time", "avg_time", "max_time", "min_time",
@@ -281,6 +285,8 @@ class ProfilerData:
         return data
 
     def get_model_perspective_perstep(self, device_type, time_unit):
+        if not self.overview_parser:
+            return
         try:
             data = OrderedDict()
             data['order'] = []
@@ -329,6 +335,8 @@ class ProfilerData:
         return new_data
 
     def get_event_type_perspective(self, device_type, time_unit):
+        if not self.overview_parser:
+            return
         data = OrderedDict()
         data['order'] = []
         if device_type == 'cpu':
@@ -416,6 +424,8 @@ class ProfilerData:
         return data
 
     def get_event_type_model_perspective(self, time_unit):  # noqa: C901
+        if not self.overview_parser:
+            return
         data = OrderedDict()
         data['order'] = []
         data['phase_type'] = []
@@ -470,6 +480,8 @@ class ProfilerData:
         return newdata
 
     def get_userdefined_perspective(self, time_unit):
+        if not self.overview_parser:
+            return
         data = OrderedDict()
         if self.overview_parser.has_device:
             data['column_name'] = [
@@ -542,6 +554,8 @@ class ProfilerData:
         return data
 
     def get_operator_pie(self, topk, time_unit='ms'):
+        if not self.operator_parser:
+            return
         data = OrderedDict()
         data['column_name'] = [
             "name", "calls", "total_time", "avg_time", "max_time", "min_time",
@@ -611,6 +625,8 @@ class ProfilerData:
 
     def get_operator_pie_expand(  # noqa: C901
             self, topk, device_type, time_unit):
+        if not self.operator_parser:
+            return
         data = OrderedDict()
         data['order'] = []
         data['phase_type'] = []
@@ -713,6 +729,9 @@ class ProfilerData:
             group_by='op_name',
             search_name=None,
             time_unit='ms'):
+        if not self.operator_parser:
+            return
+
         def get_children_data(event):
             datas = []
             for innerop_name, item in event.operator_inners.items():
@@ -1359,6 +1378,8 @@ class ProfilerData:
         return data
 
     def get_kernel_pie(self, topk, time_unit='ms'):
+        if not self.kernel_parser:
+            return
         data = OrderedDict()
         data['column_name'] = [
             "name", "calls", "total_time", "avg_time", "max_time", "min_time",
@@ -1405,6 +1426,8 @@ class ProfilerData:
         return data
 
     def get_kernel_table(self, group_by='', search_name=None, time_unit='ms'):
+        if not self.kernel_parser:
+            return
         data = OrderedDict()
         data['events'] = []
         total_gpu_time = 0
@@ -1561,6 +1584,8 @@ class ProfilerData:
         return data
 
     def get_kernel_tc_pie(self, topk, time_unit='ms'):
+        if not self.kernel_parser:
+            return
         data = OrderedDict()
         data['column_name'] = ["name", "calls", "ratio"]
 
@@ -1602,9 +1627,13 @@ class ProfilerData:
         return data
 
     def get_trace_data(self):
+        if not self.trace_parser:
+            return
         return self.trace_parser.content
 
     def get_memory_devices(self):
+        if not self.memory_parser:
+            return
         data = []
         for device in self.memory_curve.keys():
             data.append({
@@ -1620,6 +1649,8 @@ class ProfilerData:
         return data
 
     def get_memory_curve(self, device_type, time_unit='ms'):
+        if not self.memory_parser:
+            return
         curves = self.memory_curve[device_type]
         data = {}
         data['name'] = {
@@ -1647,6 +1678,8 @@ class ProfilerData:
                           max_size=float('inf'),
                           search_name=None,
                           time_unit='ms'):
+        if not self.memory_parser:
+            return
         data = {}
         data['column_name'] = [
             'MemoryAddr', 'MemoryType', 'AllocatedEvent', 'AllocatedTimestamp',
@@ -1705,6 +1738,8 @@ class ProfilerData:
         return data
 
     def get_op_memory_events(self, device_type, search_name=None):
+        if not self.memory_parser:
+            return
         data = {}
         data['column_name'] = [
             'EventName', 'MemoryType', 'AllocationCount', 'FreeCount',

visualdl/component/profiler/profiler_server.py

@@ -39,11 +39,15 @@ class ProfilerApi(object):
         if view == 'Distributed':
             return ['All']
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         return run_manager.get_workers(view)
 
     @result()
     def spans(self, run, worker):
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         if worker == 'All':
             return run_manager.get_distributed_spans()
         return run_manager.get_spans(worker)
@@ -70,8 +74,11 @@ class ProfilerApi(object):
     @result()
     def overview_environment(self, run, worker, span):
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         span = str(span)
         profiler_data = run_manager.get_profiler_data(worker, span)
+        if profiler_data:
             result = profiler_data.get_device_infos()
             num_workers = len(run_manager.get_workers('Overview'))
             result['num_workers'] = num_workers
@@ -80,7 +87,10 @@ class ProfilerApi(object):
     @result()
     def model_perspective(self, run, worker, span, time_unit='ms'):
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         profiler_data = run_manager.get_profiler_data(worker, span)
+        if profiler_data:
             return profiler_data.get_model_perspective(time_unit)
 
     @result()
@@ -92,7 +102,10 @@ class ProfilerApi(object):
                                   time_unit='ms'):
         device_type = device_type.lower()
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         profiler_data = run_manager.get_profiler_data(worker, span)
+        if profiler_data:
             return profiler_data.get_model_perspective_perstep(
                 device_type, time_unit)
 
@@ -105,26 +118,39 @@ class ProfilerApi(object):
                                time_unit='ms'):
         device_type = device_type.lower()
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         profiler_data = run_manager.get_profiler_data(worker, span)
-        return profiler_data.get_event_type_perspective(device_type, time_unit)
+        if profiler_data:
+            return profiler_data.get_event_type_perspective(
+                device_type, time_unit)
 
     @result()
     def event_type_model_perspective(self, run, worker, span, time_unit='ms'):
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         profiler_data = run_manager.get_profiler_data(worker, span)
+        if profiler_data:
             return profiler_data.get_event_type_model_perspective(time_unit)
 
     @result()
     def userdefined_perspective(self, run, worker, span, time_unit='ms'):
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         profiler_data = run_manager.get_profiler_data(worker, span)
+        if profiler_data:
             return profiler_data.get_userdefined_perspective(time_unit)
 
     @result()
     def operator_pie(self, run, worker, span, topk, time_unit='ms'):
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         profiler_data = run_manager.get_profiler_data(worker, span)
         topk = int(topk)
+        if profiler_data:
             return profiler_data.get_operator_pie(topk, time_unit)
 
     @result()
@@ -132,11 +158,14 @@ class ProfilerApi(object):
                             time_unit):
         device_type = device_type.lower()
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         profiler_data = run_manager.get_profiler_data(worker, span)
 
         topk = int(topk)
-        return profiler_data.get_operator_pie_expand(topk, device_type,
-                                                     time_unit)
+        if profiler_data:
+            return profiler_data.get_operator_pie_expand(
+                topk, device_type, time_unit)
 
     @result()
     def operator_table(self,
@@ -147,7 +176,10 @@ class ProfilerApi(object):
                        search_name,
                        time_unit='ms'):
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         profiler_data = run_manager.get_profiler_data(worker, span)
+        if profiler_data:
             return profiler_data.get_operator_table(group_by, search_name,
                                                     time_unit)
 
@@ -165,8 +197,11 @@ class ProfilerApi(object):
     @result()
     def kernel_pie(self, run, worker, span, topk, time_unit='ms'):
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         profiler_data = run_manager.get_profiler_data(worker, span)
         topk = int(topk)
+        if profiler_data:
             return profiler_data.get_kernel_pie(topk, time_unit)
 
     @result()
@@ -178,19 +213,28 @@ class ProfilerApi(object):
                      search_name,
                      time_unit='ms'):
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         profiler_data = run_manager.get_profiler_data(worker, span)
-        return profiler_data.get_kernel_table(group_by, search_name, time_unit)
+        if profiler_data:
+            return profiler_data.get_kernel_table(group_by, search_name,
+                                                  time_unit)
 
     @result()
     def kernel_tc_pie(self, run, worker, span, topk, time_unit='ms'):
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         profiler_data = run_manager.get_profiler_data(worker, span)
+        if profiler_data:
             topk = int(topk)
             return profiler_data.get_kernel_tc_pie(topk, time_unit)
 
     @result()
     def distributed_info(self, run, worker, span):
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         distributed_profiler_data = run_manager.get_distributed_profiler_data(
             span)
         if distributed_profiler_data is None:
@@ -200,6 +244,8 @@ class ProfilerApi(object):
     @result()
     def distributed_steps(self, run, worker, span):
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         distributed_profiler_data = run_manager.get_distributed_profiler_data(
             span)
         if distributed_profiler_data is None:
@@ -209,6 +255,8 @@ class ProfilerApi(object):
     @result()
     def distributed_histogram(self, run, worker, span, step, time_unit='ms'):
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         distributed_profiler_data = run_manager.get_distributed_profiler_data(
             span)
         if distributed_profiler_data is None:
@@ -219,13 +267,19 @@ class ProfilerApi(object):
     @result(headers={'content-encoding': 'gzip'})
     def trace(self, run, worker, span):
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         profiler_data = run_manager.get_profiler_data(worker, span)
+        if profiler_data:
             return profiler_data.get_trace_data()
 
     @result()
     def memory_devices(self, run, worker, span):
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         profiler_data = run_manager.get_profiler_data(worker, span)
+        if profiler_data:
             return profiler_data.get_memory_devices()
 
     @result(headers={'content-encoding': 'gzip'})
@@ -233,7 +287,10 @@ class ProfilerApi(object):
         if device_type == 'undefined':
             return
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         profiler_data = run_manager.get_profiler_data(worker, span)
+        if profiler_data:
             return profiler_data.get_memory_curve(device_type, time_unit)
 
     @result(headers={'content-encoding': 'gzip'})
@@ -259,9 +316,12 @@ class ProfilerApi(object):
         if search_name == 'undefined' or not search_name:
             search_name = None
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         profiler_data = run_manager.get_profiler_data(worker, span)
-        return profiler_data.get_memory_events(device_type, min_size, max_size,
-                                               search_name, time_unit)
+        if profiler_data:
+            return profiler_data.get_memory_events(
+                device_type, min_size, max_size, search_name, time_unit)
 
     @result(headers={'content-encoding': 'gzip'})
     def op_memory_events(self,
@@ -275,7 +335,10 @@ class ProfilerApi(object):
         if device_type == 'undefined':
             return
         run_manager = self._reader.get_run_manager(run)
+        if run_manager is None:
+            return []
         profiler_data = run_manager.get_profiler_data(worker, span)
+        if profiler_data:
             return profiler_data.get_op_memory_events(device_type, search_name)
 
     @result()

visualdl/reader/reader.py

@@ -13,6 +13,7 @@
 # limitations under the License.
 # =======================================================================
 import collections
+import os  # noqa: F401
 from functools import partial  # noqa: F401
 
 from visualdl.component import components
@@ -150,8 +151,6 @@ class LogReader(object):
         else:
             file_path = bfile.join(run, self.walks[run])
             reader = self._get_file_reader(file_path=file_path, update=False)
-            reader.dir = run
-            self.reader = reader
             remain = self.get_remain(reader=reader)
             data = self.read_log_data(
                 remain=remain, update=False)[component][tag]
@@ -276,6 +275,7 @@ class LogReader(object):
         if update:
             self.register_reader(file_path)
             self.reader = self.readers[file_path]
+            self.reader.dir = file_path
             return self.reader
         else:
             reader = RecordReader(filepath=file_path)
@@ -285,7 +285,6 @@ class LogReader(object):
         if update:
             if path not in list(self.readers.keys()):
                 reader = RecordReader(filepath=path, dir=dir)
-                reader.dir = dir
                 self.readers[path] = reader
         else:
             pass