From 8c399d53211650ffa1341d01bd9f95dd50ba0ddf Mon Sep 17 00:00:00 2001
From: wangjiawei04 <wangjiawei04@baidu.com>
Date: Mon, 6 Jul 2020 10:49:27 +0800
Subject: [PATCH] remove private-obj

---
 python/pipeline/operator.py | 40 ++++++++++++-------------------------
 1 file changed, 13 insertions(+), 27 deletions(-)

diff --git a/python/pipeline/operator.py b/python/pipeline/operator.py
index d10cd6d8..053f1ea3 100644
--- a/python/pipeline/operator.py
+++ b/python/pipeline/operator.py
@@ -126,7 +126,7 @@ class Op(object):
         channel.add_producer(self.name)
         self._outputs.append(channel)
 
-    def preprocess(self, input_dicts, private_obj):
+    def preprocess(self, input_dicts):
         # multiple previous Op
         if len(input_dicts) != 1:
             raise NotImplementedError(
@@ -136,7 +136,7 @@ class Op(object):
         (_, input_dict), = input_dicts.items()
         return input_dict
 
-    def process(self, client_predict_handler, feed_dict, private_obj):
+    def process(self, client_predict_handler, feed_dict):
         err, err_info = ChannelData.check_npdata(feed_dict)
         if err != 0:
             raise NotImplementedError(
@@ -146,7 +146,7 @@ class Op(object):
         _LOGGER.debug(self._log("get call_result"))
         return call_result
 
-    def postprocess(self, input_dict, fetch_dict, private_obj):
+    def postprocess(self, input_dict, fetch_dict):
         return fetch_dict
 
     def stop(self):
@@ -197,13 +197,10 @@ class Op(object):
     def init_op(self):
         pass
 
-    def load_private_obj(self):
-        return None
-
-    def _run_preprocess(self, parsed_data, data_id, private_obj, log_func):
+    def _run_preprocess(self, parsed_data, data_id, log_func):
         preped_data, error_channeldata = None, None
         try:
-            preped_data = self.preprocess(parsed_data, private_obj)
+            preped_data = self.preprocess(parsed_data)
         except NotImplementedError as e:
             # preprocess function not implemented
             error_info = log_func(e)
@@ -230,14 +227,14 @@ class Op(object):
         return preped_data, error_channeldata
 
     def _run_process(self, client_predict_handler, preped_data, data_id,
-                     private_obj, log_func):
+                     log_func):
         midped_data, error_channeldata = None, None
         if self.with_serving:
             ecode = ChannelDataEcode.OK.value
             if self._timeout <= 0:
                 try:
                     midped_data = self.process(client_predict_handler,
-                                               preped_data, private_obj)
+                                               preped_data)
                 except Exception as e:
                     ecode = ChannelDataEcode.UNKNOW.value
                     error_info = log_func(e)
@@ -248,8 +245,7 @@ class Op(object):
                         midped_data = func_timeout.func_timeout(
                             self._timeout,
                             self.process,
-                            args=(client_predict_handler, preped_data,
-                                  private_obj))
+                            args=(client_predict_handler, preped_data))
                     except func_timeout.FunctionTimedOut as e:
                         if i + 1 >= self._retry:
                             ecode = ChannelDataEcode.TIMEOUT.value
@@ -279,12 +275,10 @@ class Op(object):
             midped_data = preped_data
         return midped_data, error_channeldata
 
-    def _run_postprocess(self, input_dict, midped_data, data_id, private_obj,
-                         log_func):
+    def _run_postprocess(self, input_dict, midped_data, data_id, log_func):
         output_data, error_channeldata = None, None
         try:
-            postped_data = self.postprocess(input_dict, midped_data,
-                                            private_obj)
+            postped_data = self.postprocess(input_dict, midped_data)
         except Exception as e:
             error_info = log_func(e)
             _LOGGER.error(error_info)
@@ -354,14 +348,6 @@ class Op(object):
             _LOGGER.error(log(e))
             os._exit(-1)
 
-        # load private objects (some no-thread-safe objects)
-        private_obj = None
-        try:
-            private_obj = self.load_private_obj()
-        except Exception as e:
-            _LOGGER.error(log(e))
-            os._exit(-1)
-
         self._is_run = True
         while self._is_run:
             #self._profiler_record("get#{}_0".format(op_info_prefix))
@@ -380,7 +366,7 @@ class Op(object):
             # preprecess
             self._profiler_record("prep#{}_0".format(op_info_prefix))
             preped_data, error_channeldata = self._run_preprocess(
-                parsed_data, data_id, private_obj, log)
+                parsed_data, data_id, log)
             self._profiler_record("prep#{}_1".format(op_info_prefix))
             if error_channeldata is not None:
                 self._push_to_output_channels(error_channeldata,
@@ -390,7 +376,7 @@ class Op(object):
             # process
             self._profiler_record("midp#{}_0".format(op_info_prefix))
             midped_data, error_channeldata = self._run_process(
-                client_predict_handler, preped_data, data_id, private_obj, log)
+                client_predict_handler, preped_data, data_id, log)
             self._profiler_record("midp#{}_1".format(op_info_prefix))
             if error_channeldata is not None:
                 self._push_to_output_channels(error_channeldata,
@@ -400,7 +386,7 @@ class Op(object):
             # postprocess
             self._profiler_record("postp#{}_0".format(op_info_prefix))
             output_data, error_channeldata = self._run_postprocess(
-                parsed_data, midped_data, data_id, private_obj, log)
+                parsed_data, midped_data, data_id, log)
             self._profiler_record("postp#{}_1".format(op_info_prefix))
             if error_channeldata is not None:
                 self._push_to_output_channels(error_channeldata,
-- 
GitLab