From c307ee303b982c97ee66f91981f81c606c62ec63 Mon Sep 17 00:00:00 2001
From: Yan Chunwei <yanchunwei@outlook.com>
Date: Wed, 16 Aug 2017 11:31:21 +0800
Subject: [PATCH] clang format with version check (#3513)

* add clang-format with version check 3.8

* improve doc
---
 .clang_format.hook      | 15 +++++++++++++++
 .pre-commit-config.yaml |  4 ++--
 2 files changed, 17 insertions(+), 2 deletions(-)
 create mode 100755 .clang_format.hook

diff --git a/.clang_format.hook b/.clang_format.hook
new file mode 100755
index 000000000..1d9282168
--- /dev/null
+++ b/.clang_format.hook
@@ -0,0 +1,15 @@
+#!/bin/bash
+set -e
+
+readonly VERSION="3.8"
+
+version=$(clang-format -version)
+
+if ! [[ $version == *"$VERSION"* ]]; then
+    echo "clang-format version check failed."
+    echo "a version contains '$VERSION' is needed, but get '$version'"
+    echo "you can install the right version, and make an soft-link to '\$PATH' env"
+    exit -1
+fi
+
+clang-format $@
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index bb8c88787..a772125df 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -19,10 +19,10 @@
     -   id: end-of-file-fixer
 -   repo: local
     hooks:
-    -   id: clang-format
+    -   id: clang-format-with-version-check
         name: clang-format
         description: Format files with ClangFormat.
-        entry: clang-format -i
+        entry: ./.clang_format.hook -i
         language: system
         files: \.(c|cc|cxx|cpp|cu|h|hpp|hxx|proto)$
 -   repo: https://github.com/PaddlePaddle/pre-commit-golang
-- 
GitLab