From 89cb3a249cc5ecbf3955ea37e67655ec431142e3 Mon Sep 17 00:00:00 2001
From: tensor-tang <jian.j.tang@intel.com>
Date: Wed, 3 Jan 2018 14:02:01 +0800
Subject: [PATCH] follow comments, refine comment and function name

---
 paddle/gserver/layers/MKLPackedRecurrentLayer.cpp | 4 ++--
 paddle/gserver/layers/MKLPackedRecurrentLayer.h   | 6 +++---
 paddle/gserver/layers/MKLPackedWeight.h           | 6 +++---
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/paddle/gserver/layers/MKLPackedRecurrentLayer.cpp b/paddle/gserver/layers/MKLPackedRecurrentLayer.cpp
index b4a641304..dd75555fa 100644
--- a/paddle/gserver/layers/MKLPackedRecurrentLayer.cpp
+++ b/paddle/gserver/layers/MKLPackedRecurrentLayer.cpp
@@ -59,7 +59,7 @@ void MKLPackedRecurrentLayer::forwardBatch(int batchSize,
         MatrixPtr preBatchValue =
             batchValue_->getBatchValue(n - 1, batchValue->getHeight());
 
-        packed_weight_->compute(batchValue, preBatchValue);
+        packed_weight_->gemm_compute(preBatchValue, batchValue);
       }
       Argument arg;
       arg.value = batchValue;
@@ -96,7 +96,7 @@ void MKLPackedRecurrentLayer::backwardBatch(int batchSize,
 
       if (n != 0) {
         batchValue = batchGrad_->getBatchValue(n - 1, batchGrad->getHeight());
-        packed_weightT_->compute(batchValue, batchGrad);
+        packed_weightT_->gemm_compute(batchGrad, batchValue);
       }
 
       if (backwardByBatch && weight_->getWGrad()) {
diff --git a/paddle/gserver/layers/MKLPackedRecurrentLayer.h b/paddle/gserver/layers/MKLPackedRecurrentLayer.h
index 19874d538..bded523a8 100644
--- a/paddle/gserver/layers/MKLPackedRecurrentLayer.h
+++ b/paddle/gserver/layers/MKLPackedRecurrentLayer.h
@@ -22,8 +22,8 @@ DECLARE_bool(rnn_use_batch);
 namespace paddle {
 
 /**
- * @brief MKLPackedRecurrentLayer is same with RecurrentLayer but is optimized
- * with MKL cblas packed gemm.
+ * @brief MKLPackedRecurrentLayer is almost the same with RecurrentLayer
+ * but is optimized with MKL cblas packed gemm.
  * More details:
  * https://github.com/PaddlePaddle/Paddle/blob/develop/doc/design/mkl/mkl_packed.md
  */
@@ -48,7 +48,7 @@ protected:
                      const int* starts) override;
 
 protected:
-  /// packed_weight_ is contains same data with
+  /// packed_weight_ contains same data with
   /// RecurrentLayer::weight_ but is packed
   std::unique_ptr<MKLPackedWeight> packed_weight_;
   /// packed_weightT_ is the transposition matrix of packed_weight_
diff --git a/paddle/gserver/layers/MKLPackedWeight.h b/paddle/gserver/layers/MKLPackedWeight.h
index f77aa4dbb..15d5093be 100644
--- a/paddle/gserver/layers/MKLPackedWeight.h
+++ b/paddle/gserver/layers/MKLPackedWeight.h
@@ -22,9 +22,9 @@ namespace paddle {
 
 class MKLPackedWeight {
 protected:
-  /// The pointor of weight
+  /// The pointer of weight
   real *weight_;
-  /// The pointor of cblas packed gemm to weight
+  /// The pointer of cblas packed gemm to weight
   real *packedWeight_;
   size_t height_;
   size_t width_;
@@ -43,7 +43,7 @@ public:
 
   void pack() { pack_(weight_); }
 
-  void compute(MatrixPtr dst, const MatrixPtr src) {
+  void gemm_compute(const MatrixPtr src, MatrixPtr dst) {
     cblas_sgemm_compute(CblasRowMajor,
                         CblasNoTrans,
                         CblasPacked,
-- 
GitLab