From 2d3c186a96178132784ecb9ba81403b67c3b7f67 Mon Sep 17 00:00:00 2001
From: Yu Yang <yuyang18@baidu.com>
Date: Thu, 29 Jun 2017 14:14:55 +0800
Subject: [PATCH] Follow comments

---
 cmake/generic.cmake  | 6 ++++--
 proto/CMakeLists.txt | 1 +
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/cmake/generic.cmake b/cmake/generic.cmake
index 779f62711..8117dbc53 100644
--- a/cmake/generic.cmake
+++ b/cmake/generic.cmake
@@ -87,6 +87,9 @@
 #   go_library(example SHARED)
 #
 
+# including binary directory for generated headers.
+include_directories(${CMAKE_CURRENT_BINARY_DIR})
+
 if(NOT APPLE)
     find_package(Threads REQUIRED)
     link_libraries(${CMAKE_THREAD_LIBS_INIT})
@@ -339,6 +342,5 @@ function(proto_library TARGET_NAME)
   set(proto_srcs)
   set(proto_hdrs)
   protobuf_generate_cpp(proto_srcs proto_hdrs ${proto_library_SRCS})
-  include_directories(${CMAKE_CURRENT_BINARY_DIR})
-  cc_library(${TARGET_NAME} SRCS ${proto_srcs})
+  cc_library(${TARGET_NAME} SRCS ${proto_srcs} DEPS protobuf)
 endfunction()
diff --git a/proto/CMakeLists.txt b/proto/CMakeLists.txt
index 70dd4d674..18584cafe 100644
--- a/proto/CMakeLists.txt
+++ b/proto/CMakeLists.txt
@@ -1,4 +1,5 @@
 file(GLOB proto_filenames . *.proto)
+include_directories(${CMAKE_CURRENT_BINARY_DIR})
 proto_library(paddle_proto SRCS ${proto_filenames})
 
 set(PROTO_GEN)
-- 
GitLab