From 1ed5ae7a14b9a740cb0f0e892cd6c12de5a293e4 Mon Sep 17 00:00:00 2001
From: Yi Wang <wangkuiyi@users.noreply.github.com>
Date: Thu, 2 Nov 2017 20:26:54 -0700
Subject: [PATCH] Fix comparing between signed and unsigned values (#5328)

---
 paddle/framework/executor.cc                  | 2 +-
 paddle/gserver/evaluators/Evaluator.cpp       | 2 +-
 paddle/operators/seq_expand_op.h              | 3 ++-
 paddle/optimizer/parameter_optimizer_test.cpp | 2 +-
 4 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/paddle/framework/executor.cc b/paddle/framework/executor.cc
index f8d32de5d..52fefe4ea 100644
--- a/paddle/framework/executor.cc
+++ b/paddle/framework/executor.cc
@@ -83,7 +83,7 @@ void Executor::Run(const ProgramDescBind& pdesc, Scope* scope, int block_id,
   // TODO(tonyyang-svail):
   //    - only runs on the first device (i.e. no interdevice communication)
   //    - will change to use multiple blocks for RNN op and Cond Op
-  PADDLE_ENFORCE_LT(block_id, pdesc.Size());
+  PADDLE_ENFORCE_LT(static_cast<size_t>(block_id), pdesc.Size());
   auto& block = pdesc.Block(block_id);
   auto& device = device_contexts_[0];
 
diff --git a/paddle/gserver/evaluators/Evaluator.cpp b/paddle/gserver/evaluators/Evaluator.cpp
index 87cb2d280..8e66b1f0d 100644
--- a/paddle/gserver/evaluators/Evaluator.cpp
+++ b/paddle/gserver/evaluators/Evaluator.cpp
@@ -407,7 +407,7 @@ real AucEvaluator::evalImp(std::vector<Argument>& arguments) {
   // Copy label from value to a vector.
   if (nullptr == label && nullptr != labelval) {
     // label width is 1
-    CHECK_EQ(1, labelval->getWidth());
+    CHECK_EQ(1U, labelval->getWidth());
     VectorPtr vec =
         Vector::create(labelval->getData(), insNum, output->useGpu());
     label = vec->castToInt();
diff --git a/paddle/operators/seq_expand_op.h b/paddle/operators/seq_expand_op.h
index 870310538..4ef0d02cf 100644
--- a/paddle/operators/seq_expand_op.h
+++ b/paddle/operators/seq_expand_op.h
@@ -32,7 +32,8 @@ class SeqExpandKernel : public framework::OpKernel<T> {
     const T* x_data = x->data<T>();
     auto x_dims = x->dims();
     auto* y = context.Input<LoDTensor>("Y");
-    PADDLE_ENFORCE_EQ(x_dims[0], y->lod().back().size() - 1,
+    PADDLE_ENFORCE_EQ(static_cast<size_t>(x_dims[0]),
+                      y->lod().back().size() - 1,
                       "The size of last lod level in Input(Y)"
                       "must be equal to dims[0] of Input(X).");
     out->set_lod(y->lod());
diff --git a/paddle/optimizer/parameter_optimizer_test.cpp b/paddle/optimizer/parameter_optimizer_test.cpp
index c88fa1174..c99b2254a 100644
--- a/paddle/optimizer/parameter_optimizer_test.cpp
+++ b/paddle/optimizer/parameter_optimizer_test.cpp
@@ -85,7 +85,7 @@ public:
     for (size_t i = 0; i < opts_.size(); ++i) {
       int s = 0;
       float* newp = (float*)opts_[i]->get_weight(&s);
-      EXPECT_EQ(s, kSize);
+      EXPECT_EQ(static_cast<size_t>(s), kSize);
       for (size_t j = 0; j < kSize; ++j) {
         EXPECT_EQ(newp[j], (*p)[j]);
       }
-- 
GitLab