From c9f8b87ef493271def6cdf2351ad6988218db24d Mon Sep 17 00:00:00 2001
From: xiongkun <xiongkun03@baidu.com>
Date: Tue, 8 Nov 2022 03:35:10 +0000
Subject: [PATCH] fix by code review

---
 test_tipc/{loss_filter.py => extract_loss.py} |  1 -
 ...ness.sh => test_train_dy2static_python.sh} | 20 ++-----------------
 2 files changed, 2 insertions(+), 19 deletions(-)
 rename test_tipc/{loss_filter.py => extract_loss.py} (99%)
 rename test_tipc/{test_dy2static_correctness.sh => test_train_dy2static_python.sh} (75%)

diff --git a/test_tipc/loss_filter.py b/test_tipc/extract_loss.py
similarity index 99%
rename from test_tipc/loss_filter.py
rename to test_tipc/extract_loss.py
index c0fc2274..267d0d91 100644
--- a/test_tipc/loss_filter.py
+++ b/test_tipc/extract_loss.py
@@ -4,7 +4,6 @@ import re
 
 
 def parameter_parser():
-    import argparse
     parser = argparse.ArgumentParser(description="Support Args:")
     parser.add_argument(
         "-v",
diff --git a/test_tipc/test_dy2static_correctness.sh b/test_tipc/test_train_dy2static_python.sh
similarity index 75%
rename from test_tipc/test_dy2static_correctness.sh
rename to test_tipc/test_train_dy2static_python.sh
index e3cd1a82..a4a990d7 100644
--- a/test_tipc/test_dy2static_correctness.sh
+++ b/test_tipc/test_train_dy2static_python.sh
@@ -1,25 +1,9 @@
 #!/bin/bash
 source test_tipc/common_func.sh
 
-function readlinkf() {
-    perl -MCwd -e 'print Cwd::abs_path shift' "$1";
-}
-
-function func_parser_config() {
-    strs=$1
-    IFS=" "
-    array=(${strs})
-    tmp=${array[2]}
-    echo ${tmp}
-}
-
 # always use the lite_train_lite_infer mode to speed. Modify the config file.
 MODE=lite_train_lite_infer
 BASEDIR=$(dirname "$0")
-REPO_ROOT_PATH=$(readlinkf ${BASEDIR}/../)
-
-echo $BASEDIR
-echo $REPO_ROOT_PATH
 
 FILENAME=$1
 sed -i 's/gpu_list.*$/gpu_list:0/g' $FILENAME
@@ -52,8 +36,8 @@ echo $cmd
 eval $cmd
 
 # analysis and compare the losses. 
-dyout=`cat $dy2static_output | python3 test_tipc/loss_filter.py -v 'Iter:' -e 'loss: {%f},'`
-stout=`cat $dygraph_output | python3 test_tipc/loss_filter.py -v 'Iter:' -e 'loss: {%f},'  `
+dyout=`cat $dy2static_output | python3 test_tipc/extract_loss.py -v 'Iter:' -e 'loss: {%f},'`
+stout=`cat $dygraph_output | python3 test_tipc/extract_loss.py -v 'Iter:' -e 'loss: {%f},'  `
 echo $dyout
 echo $stout
 if [ "$dyout" = "" ]; then
-- 
GitLab