From f1d61e675ceeffbd00391038e489b6d24de631b1 Mon Sep 17 00:00:00 2001
From: Yu Yang <yuyang18@baidu.com>
Date: Wed, 7 Mar 2018 10:43:37 +0800
Subject: [PATCH] Add magic number in recordio

---
 paddle/fluid/recordio/header.cc | 8 +++++++-
 paddle/fluid/recordio/header.h  | 2 --
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/paddle/fluid/recordio/header.cc b/paddle/fluid/recordio/header.cc
index 3641caaa898..71d64a62a1e 100644
--- a/paddle/fluid/recordio/header.cc
+++ b/paddle/fluid/recordio/header.cc
@@ -13,6 +13,7 @@
 // limitations under the License.
 
 #include "paddle/fluid/recordio/header.h"
+#include "paddle/fluid/platform/enforce.h"
 
 namespace paddle {
 namespace recordio {
@@ -27,6 +28,10 @@ Header::Header(uint32_t num, uint32_t sum, Compressor c, uint32_t cs)
     : num_records_(num), checksum_(sum), compressor_(c), compress_size_(cs) {}
 
 void Header::Parse(std::istream& is) {
+  uint32_t magic;
+  is.read(reinterpret_cast<char*>(&magic), sizeof(uint32_t));
+  PADDLE_ENFORCE_EQ(magic, kMagicNumber);
+
   is.read(reinterpret_cast<char*>(&num_records_), sizeof(uint32_t))
       .read(reinterpret_cast<char*>(&checksum_), sizeof(uint32_t))
       .read(reinterpret_cast<char*>(&compressor_), sizeof(uint32_t))
@@ -34,7 +39,8 @@ void Header::Parse(std::istream& is) {
 }
 
 void Header::Write(std::ostream& os) const {
-  os.write(reinterpret_cast<const char*>(&num_records_), sizeof(uint32_t))
+  os.write(reinterpret_cast<const char*>(&kMagicNumber), sizeof(uint32_t))
+      .write(reinterpret_cast<const char*>(&num_records_), sizeof(uint32_t))
       .write(reinterpret_cast<const char*>(&checksum_), sizeof(uint32_t))
       .write(reinterpret_cast<const char*>(&compressor_), sizeof(uint32_t))
       .write(reinterpret_cast<const char*>(&compress_size_), sizeof(uint32_t));
diff --git a/paddle/fluid/recordio/header.h b/paddle/fluid/recordio/header.h
index cbd52642a66..77f2f3a597a 100644
--- a/paddle/fluid/recordio/header.h
+++ b/paddle/fluid/recordio/header.h
@@ -19,8 +19,6 @@
 namespace paddle {
 namespace recordio {
 
-// Default ChunkSize
-constexpr size_t kDefaultMaxChunkSize = 32 * 1024 * 1024;
 // MagicNumber for memory checking
 constexpr uint32_t kMagicNumber = 0x01020304;
 
-- 
GitLab