From e4247120732e665af866468b5a0971b7bb99f25d Mon Sep 17 00:00:00 2001
From: liym27 <33742067+liym27@users.noreply.github.com>
Date: Wed, 17 Mar 2021 21:41:55 +0800
Subject: [PATCH] [NPU] Fix bug: Fix calculation errors of pow grad npu kernel
 (#31699)

---
 paddle/fluid/operators/activation_op_npu.cc | 31 ++++++++-------------
 1 file changed, 11 insertions(+), 20 deletions(-)

diff --git a/paddle/fluid/operators/activation_op_npu.cc b/paddle/fluid/operators/activation_op_npu.cc
index 2f899825c5c..1a843bfc991 100644
--- a/paddle/fluid/operators/activation_op_npu.cc
+++ b/paddle/fluid/operators/activation_op_npu.cc
@@ -92,7 +92,7 @@ class PowGradNPUKernel : public framework::OpKernel<T> {
     Tensor x_power_mul_factor(x->type());
     x_power_mul_factor.mutable_data<T>(x->dims(), place);
     auto runner_mul_1 =
-        NpuOpRunner("Mul", {factor_bc_tensor, *x}, {x_power_mul_factor}, {});
+        NpuOpRunner("Mul", {factor_bc_tensor, x_pow}, {x_power_mul_factor}, {});
     runner_mul_1.Run(stream);
 
     // Step 4: Compute dx = dout * factor * x.pow(factor-1)
@@ -309,20 +309,17 @@ class SquareNPUKernel : public framework::OpKernel<T> {
 namespace ops = paddle::operators;
 
 REGISTER_OP_NPU_KERNEL(
-    pow,
-    ops::PowNPUKernel<paddle::platform::NPUDeviceContext, float>,
+    pow, ops::PowNPUKernel<paddle::platform::NPUDeviceContext, float>,
     ops::PowNPUKernel<paddle::platform::NPUDeviceContext,
                       paddle::platform::float16>);
 
 REGISTER_OP_NPU_KERNEL(
-    pow_grad,
-    ops::PowGradNPUKernel<paddle::platform::NPUDeviceContext, float>,
+    pow_grad, ops::PowGradNPUKernel<paddle::platform::NPUDeviceContext, float>,
     ops::PowGradNPUKernel<paddle::platform::NPUDeviceContext,
                           paddle::platform::float16>);
 
 REGISTER_OP_NPU_KERNEL(
-    relu,
-    ops::ReluNPUKernel<paddle::platform::NPUDeviceContext, float>,
+    relu, ops::ReluNPUKernel<paddle::platform::NPUDeviceContext, float>,
     ops::ReluNPUKernel<paddle::platform::NPUDeviceContext,
                        paddle::platform::float16>);
 
@@ -333,33 +330,28 @@ REGISTER_OP_NPU_KERNEL(
                            paddle::platform::float16>);
 
 REGISTER_OP_NPU_KERNEL(
-    sqrt,
-    ops::SqrtNPUKernel<paddle::platform::NPUDeviceContext, float>,
+    sqrt, ops::SqrtNPUKernel<paddle::platform::NPUDeviceContext, float>,
     ops::SqrtNPUKernel<paddle::platform::NPUDeviceContext,
-                      paddle::platform::float16>);
+                       paddle::platform::float16>);
 
 REGISTER_OP_NPU_KERNEL(
     sqrt_grad,
     ops::SqrtGradNPUKernel<paddle::platform::NPUDeviceContext, float>,
     ops::SqrtGradNPUKernel<paddle::platform::NPUDeviceContext,
-                          paddle::platform::float16>);
+                           paddle::platform::float16>);
 
 REGISTER_OP_NPU_KERNEL(
-    log,
-    ops::LogNPUKernel<paddle::platform::NPUDeviceContext, float>,
+    log, ops::LogNPUKernel<paddle::platform::NPUDeviceContext, float>,
     ops::LogNPUKernel<paddle::platform::NPUDeviceContext,
                       paddle::platform::float16>);
 
 REGISTER_OP_NPU_KERNEL(
-    log_grad,
-    ops::LogGradNPUKernel<paddle::platform::NPUDeviceContext, float>,
+    log_grad, ops::LogGradNPUKernel<paddle::platform::NPUDeviceContext, float>,
     ops::LogGradNPUKernel<paddle::platform::NPUDeviceContext,
                           paddle::platform::float16>);
 
-
 REGISTER_OP_NPU_KERNEL(
-    tanh,
-    ops::TanhNPUKernel<paddle::platform::NPUDeviceContext, float>,
+    tanh, ops::TanhNPUKernel<paddle::platform::NPUDeviceContext, float>,
     ops::TanhNPUKernel<paddle::platform::NPUDeviceContext,
                        paddle::platform::float16>);
 
@@ -370,7 +362,6 @@ REGISTER_OP_NPU_KERNEL(
                            paddle::platform::float16>);
 
 REGISTER_OP_NPU_KERNEL(
-    square,
-    ops::SquareNPUKernel<paddle::platform::NPUDeviceContext, float>,
+    square, ops::SquareNPUKernel<paddle::platform::NPUDeviceContext, float>,
     ops::SquareNPUKernel<paddle::platform::NPUDeviceContext,
                          paddle::platform::float16>);
-- 
GitLab