From cbf8ba1591ee3316e78efe3cdf4d99e73c4259c9 Mon Sep 17 00:00:00 2001
From: Dong Daxiang <35550832+guru4elephant@users.noreply.github.com>
Date: Sun, 16 Aug 2020 11:19:32 +0800
Subject: [PATCH] add check approval (#26284)

test=develop
---
 python/paddle/fluid/optimizer.py   | 2 +-
 tools/check_file_diff_approvals.sh | 8 ++++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/python/paddle/fluid/optimizer.py b/python/paddle/fluid/optimizer.py
index 740db0d4b9e..d7e6a9d211b 100644
--- a/python/paddle/fluid/optimizer.py
+++ b/python/paddle/fluid/optimizer.py
@@ -754,7 +754,7 @@ class Optimizer(object):
                 params_grads = append_backward(loss, parameter_list,
                                                act_no_grad_set, callbacks)
                 # Note: since we can't use all_reduce_op now,
-                #  dgc_op should be the last op of one grad.
+                # dgc_op should be the last op of one grad.
                 self._append_dgc_ops(params_grads)
         return params_grads
 
diff --git a/tools/check_file_diff_approvals.sh b/tools/check_file_diff_approvals.sh
index e2f37bb9aa2..2c575e4abf1 100644
--- a/tools/check_file_diff_approvals.sh
+++ b/tools/check_file_diff_approvals.sh
@@ -19,7 +19,8 @@ API_FILES=("CMakeLists.txt"
            "paddle/fluid/framework/ir/node.h"
            "paddle/fluid/framework/ir/graph.h"
            "paddle/fluid/framework/framework.proto"
-	   "python/paddle/fleet/__init__.py"
+	   "python/paddle/distributed/__init"
+	   "python/paddle/distributed/fleet/__init__.py"
            "python/requirements.txt"
            "python/paddle/fluid/__init__.py"
            "python/paddle/fluid/compiler.py"
@@ -118,7 +119,10 @@ for API_FILE in ${API_FILES[*]}; do
       elif [ "${API_FILE}" == "tools/wlist.json" ];then
         echo_line="You must have one TPM (jzhang533) approval for the api whitelist for the tools/wlist.json.\n"
         check_approval 1 29231
-      elif [ "${API_FILE}" == "python/paddle/fleet/__init__.py" ]; then
+      elif [ "${API_FILE}" == "python/paddle/distributed/fleet/__init__.py" ]; then
+	echo_line="You must have (guru4elephant,raindrops2sea) approval for ${API_FILE} changes "
+	check_approval 1 35550832 38231817
+      elif [ "${API_FILE}" == "python/paddle/distributed/__init__.py" ]; then
 	echo_line="You must have (guru4elephant,raindrops2sea) approval for ${API_FILE} changes "
 	check_approval 1 35550832 38231817
       else
-- 
GitLab