From c22c2c58a06ad9e646c435242ea8d4eb78a72e14 Mon Sep 17 00:00:00 2001
From: wanghuancoder <wanghuan29@baidu.com>
Date: Mon, 9 May 2022 17:17:49 +0800
Subject: [PATCH] refine pylayer (#42572)

* refine pylayer

* refine
---
 paddle/fluid/eager/pylayer/py_layer_node.cc | 5 +++--
 paddle/fluid/eager/pylayer/py_layer_node.h  | 9 +--------
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/paddle/fluid/eager/pylayer/py_layer_node.cc b/paddle/fluid/eager/pylayer/py_layer_node.cc
index fad4fd50a5e..a00b292fe09 100644
--- a/paddle/fluid/eager/pylayer/py_layer_node.cc
+++ b/paddle/fluid/eager/pylayer/py_layer_node.cc
@@ -106,8 +106,6 @@ GradNodePyLayer::operator()(
         pybind11::detail::error_string().c_str()));
   }
 
-  outputs_ = outputs;
-
   VLOG(6) << "PyLayer backward function finish...";
 
   PyObject* outputs_tuple = nullptr;
@@ -165,6 +163,9 @@ GradNodePyLayer::operator()(
   if (!PyTuple_Check(outputs)) {
     Py_XDECREF(outputs_tuple);
   }
+  Py_XDECREF(outputs);
+  Py_XDECREF(ctx_);
+  ctx_ = nullptr;
 
   return grad_out;
 }
diff --git a/paddle/fluid/eager/pylayer/py_layer_node.h b/paddle/fluid/eager/pylayer/py_layer_node.h
index b477d7a9ad9..c1a8c6e626b 100644
--- a/paddle/fluid/eager/pylayer/py_layer_node.h
+++ b/paddle/fluid/eager/pylayer/py_layer_node.h
@@ -32,10 +32,7 @@ class GradNodePyLayer : public GradNodeBase {
     ctx_ = ctx;
   }
 
-  ~GradNodePyLayer() override {
-    Py_DECREF(ctx_);
-    Py_XDECREF(outputs_);
-  };
+  ~GradNodePyLayer() override { Py_XDECREF(ctx_); };
 
   virtual paddle::small_vector<std::vector<paddle::experimental::Tensor>,
                                kSlotSmallVectorSize>
@@ -50,9 +47,6 @@ class GradNodePyLayer : public GradNodeBase {
     return "GradNodePyLayer_" + std::string(Py_TYPE(ctx_)->tp_name);
   }
 
-  // for paddle.grad get result
-  PyObject* GetMutableOutputs() { return outputs_; }
-
   void SaveForwardOutputsMeta(
       const std::vector<std::vector<paddle::experimental::Tensor*>>&
           outputs_tensor) {
@@ -81,7 +75,6 @@ class GradNodePyLayer : public GradNodeBase {
 
  private:
   PyObject* ctx_{nullptr};
-  PyObject* outputs_{nullptr};
   std::vector<std::vector<phi::DenseTensorMeta>> forward_outputs_meta_;
   std::vector<std::vector<paddle::platform::Place>> forward_outputs_place_;
 };
-- 
GitLab