From c0f5dac6179bb565f8b2cede87793932a978cdb4 Mon Sep 17 00:00:00 2001 From: Zhenghai Zhang <65210872+ccsuzzh@users.noreply.github.com> Date: Mon, 28 Aug 2023 16:50:51 +0800 Subject: [PATCH] [clang-tidy] NO.65 enable `clang-analyzer-cplusplus.InnerPointer` check (#56693) * enable clang-analyzer-cplusplus.InnerPointer check * fix bug --- .clang-tidy | 2 +- paddle/phi/kernels/funcs/math_function.cc | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 518fb18aca0..bddfa51ab23 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -67,7 +67,7 @@ bugprone-unused-raii, -clang-analyzer-core.uninitialized.Branch, -clang-analyzer-core.uninitialized.CapturedBlockVariable, -clang-analyzer-core.uninitialized.UndefReturn, --clang-analyzer-cplusplus.InnerPointer, +clang-analyzer-cplusplus.InnerPointer, -clang-analyzer-cplusplus.Move, -clang-analyzer-cplusplus.NewDelete, -clang-analyzer-cplusplus.NewDeleteLeaks, diff --git a/paddle/phi/kernels/funcs/math_function.cc b/paddle/phi/kernels/funcs/math_function.cc index a0c506a37d8..38ab18dca71 100644 --- a/paddle/phi/kernels/funcs/math_function.cc +++ b/paddle/phi/kernels/funcs/math_function.cc @@ -277,16 +277,14 @@ struct RowwiseAdd { " Expected vector size=%d, but received %d", size, vector.numel())); - const char* in_dims_cstr = in_dims.to_str().c_str(); - const char* out_dims_cstr = out_dims.to_str().c_str(); PADDLE_ENFORCE_EQ(out_dims, in_dims, phi::errors::InvalidArgument( "The output tensor shape should be same as the input" " tensor shape. Expected output tensor shape: %s," " but received %s", - in_dims_cstr, - out_dims_cstr)); + in_dims.to_str().c_str(), + out_dims.to_str().c_str())); auto in = phi::EigenMatrix::From(input); auto vec = phi::EigenVector::Flatten(vector); -- GitLab