From 9283233650402d7d8ede578784a3df690fd2d155 Mon Sep 17 00:00:00 2001 From: Yi Wang Date: Sat, 5 Aug 2017 16:16:58 -0700 Subject: [PATCH] Mark the reason of using a personal repo temporarily --- cmake/external/gflags.cmake | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/cmake/external/gflags.cmake b/cmake/external/gflags.cmake index c34359d08bc..16e5bef4cdb 100644 --- a/cmake/external/gflags.cmake +++ b/cmake/external/gflags.cmake @@ -28,6 +28,13 @@ INCLUDE_DIRECTORIES(${GFLAGS_INCLUDE_DIR}) ExternalProject_Add( extern_gflags ${EXTERNAL_PROJECT_LOG_ARGS} + # TODO(yiwang): The annoying warnings mentioned in + # https://github.com/PaddlePaddle/Paddle/issues/3277 are caused by + # gflags. I fired a PR https://github.com/gflags/gflags/pull/230 + # to fix it. Before it gets accepted by the gflags team, we use + # my personal fork, which contains above fix, temporarily. Let's + # change this back to the official Github repo once my PR is + # merged. GIT_REPOSITORY "https://github.com/wangkuiyi/gflags.git" PREFIX ${GFLAGS_SOURCES_DIR} UPDATE_COMMAND "" -- GitLab