From 700fdb1819893741bb8ced31bb03d18d54d0f8b7 Mon Sep 17 00:00:00 2001 From: Adam <38704900+grygielski@users.noreply.github.com> Date: Mon, 6 Jan 2020 06:34:43 +0100 Subject: [PATCH] MKL-DNN 1.1 for Windows (#22089) --- cmake/external/mkldnn.cmake | 23 ++++++++++++++--------- cmake/inference_lib.cmake | 2 +- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/cmake/external/mkldnn.cmake b/cmake/external/mkldnn.cmake index 04e603e787d..3a59ce6a341 100644 --- a/cmake/external/mkldnn.cmake +++ b/cmake/external/mkldnn.cmake @@ -19,14 +19,7 @@ SET(MKLDNN_PREFIX_DIR ${THIRD_PARTY_PATH}/mkldnn) SET(MKLDNN_INSTALL_DIR ${THIRD_PARTY_PATH}/install/mkldnn) SET(MKLDNN_INC_DIR "${MKLDNN_INSTALL_DIR}/include" CACHE PATH "mkldnn include directory." FORCE) SET(MKLDNN_REPOSITORY https://github.com/intel/mkl-dnn.git) - -if(WIN32) - # For Windows use 1.0 version of MKL-DNN - SET(MKLDNN_TAG 518a316a8cd6deb82dc7866bc04bd0355a25c3a4) -else(WIN32) - SET(MKLDNN_TAG 52c3052df8ec1d5b8b45cb6c350a952840eabd42) -endif(WIN32) - +SET(MKLDNN_TAG 52c3052df8ec1d5b8b45cb6c350a952840eabd42) # Introduce variables: # * CMAKE_INSTALL_LIBDIR @@ -82,7 +75,7 @@ ExternalProject_Add( CMAKE_CACHE_ARGS -DCMAKE_INSTALL_PREFIX:PATH=${MKLDNN_INSTALL_DIR} ) if(WIN32) - SET(MKLDNN_LIB "${MKLDNN_INSTALL_DIR}/${LIBDIR}/mkldnn.lib" CACHE FILEPATH "mkldnn library." FORCE) + SET(MKLDNN_LIB "${MKLDNN_INSTALL_DIR}/bin/mkldnn.lib" CACHE FILEPATH "mkldnn library." FORCE) else(WIN32) SET(MKLDNN_LIB "${MKLDNN_INSTALL_DIR}/${LIBDIR}/libdnnl.so" CACHE FILEPATH "mkldnn library." FORCE) endif(WIN32) @@ -105,6 +98,18 @@ ADD_DEPENDENCIES(mkldnn ${MKLDNN_PROJECT}) # it can be directly contained in wheel or capi if(WIN32) SET(MKLDNN_SHARED_LIB ${MKLDNN_INSTALL_DIR}/bin/mkldnn.dll) + ADD_CUSTOM_COMMAND(TARGET ${MKLDNN_PROJECT} POST_BUILD + COMMAND ${CMAKE_COMMAND} -E copy ${MKLDNN_INSTALL_DIR}/bin/dnnl.dll ${MKLDNN_SHARED_LIB}) + add_custom_command(TARGET ${MKLDNN_PROJECT} POST_BUILD VERBATIM + COMMAND dumpbin /exports ${MKLDNN_INSTALL_DIR}/bin/mkldnn.dll > ${MKLDNN_INSTALL_DIR}/bin/exports.txt) + add_custom_command(TARGET ${MKLDNN_PROJECT} POST_BUILD VERBATIM + COMMAND echo LIBRARY mkldnn > ${MKLDNN_INSTALL_DIR}/bin/mkldnn.def) + add_custom_command(TARGET ${MKLDNN_PROJECT} POST_BUILD VERBATIM + COMMAND echo EXPORTS >> ${MKLDNN_INSTALL_DIR}/bin/mkldnn.def) + add_custom_command(TARGET ${MKLDNN_PROJECT} POST_BUILD VERBATIM + COMMAND for /f "skip=19 tokens=4" %A in (${MKLDNN_INSTALL_DIR}/bin/exports.txt) do echo %A >> ${MKLDNN_INSTALL_DIR}/bin/mkldnn.def) + add_custom_command(TARGET ${MKLDNN_PROJECT} POST_BUILD VERBATIM + COMMAND lib /def:${MKLDNN_INSTALL_DIR}/bin/mkldnn.def /out:${MKLDNN_INSTALL_DIR}/bin/mkldnn.lib /machine:x64) else(WIN32) SET(MKLDNN_SHARED_LIB ${MKLDNN_INSTALL_DIR}/libmkldnn.so.0) SET(MKLDNN_SHARED_LIB_1 ${MKLDNN_INSTALL_DIR}/libdnnl.so.1) diff --git a/cmake/inference_lib.cmake b/cmake/inference_lib.cmake index 0eabf89d364..a08668257b0 100644 --- a/cmake/inference_lib.cmake +++ b/cmake/inference_lib.cmake @@ -86,7 +86,7 @@ function(copy_part_of_thrid_party TARGET DST) set(dst_dir "${DST}/third_party/install/mkldnn") if(WIN32) copy(${TARGET} - SRCS ${MKLDNN_INC_DIR} ${MKLDNN_SHARED_LIB} ${MKLDNN_LIB} + SRCS ${MKLDNN_INC_DIR} ${MKLDNN_SHARED_LIB} ${MKLDNN_LIB} DSTS ${dst_dir} ${dst_dir}/lib ${dst_dir}/lib) else() copy(${TARGET} -- GitLab