未验证 提交 4e1f7692 编写于 作者: W wanghuancoder 提交者: GitHub

[Eager]release gil when run backward (#44433)

* release gil when run backward
上级 547075e9
......@@ -34,6 +34,7 @@ GradNodePyLayer::operator()(
kSlotSmallVectorSize>& grads, // NOLINT
bool create_graph,
bool is_new_grad) {
pybind11::gil_scoped_acquire gil;
VLOG(3) << "Running Eager Backward Node: " << name();
paddle::small_vector<std::vector<paddle::experimental::Tensor>,
......
......@@ -119,9 +119,12 @@ static PyObject* eager_api_run_backward(PyObject* self,
EAGER_TRY
auto tensors = CastPyArg2VectorOfTensor(PyTuple_GET_ITEM(args, 0), 0);
auto grad_tensors = CastPyArg2VectorOfTensor(PyTuple_GET_ITEM(args, 1), 1);
{
eager_gil_scoped_release guard;
egr::Backward(tensors,
grad_tensors,
CastPyArg2AttrBoolean(PyTuple_GET_ITEM(args, 2), 2));
}
RETURN_PY_NONE
EAGER_CATCH_AND_THROW_RETURN_NULL
}
......@@ -138,8 +141,10 @@ static PyObject* eager_api_run_partial_grad(PyObject* self,
auto only_inputs = CastPyArg2AttrBoolean(PyTuple_GET_ITEM(args, 5), 5);
auto allow_unused = CastPyArg2AttrBoolean(PyTuple_GET_ITEM(args, 6), 6);
auto no_grad_vars = CastPyArg2VectorOfTensor(PyTuple_GET_ITEM(args, 7), 7);
std::vector<paddle::experimental::Tensor> result = egr::Grad(tensors,
std::vector<paddle::experimental::Tensor> result;
{
eager_gil_scoped_release guard;
result = egr::Grad(tensors,
inputs,
grad_tensors,
retain_graph,
......@@ -147,6 +152,7 @@ static PyObject* eager_api_run_partial_grad(PyObject* self,
only_inputs,
allow_unused,
no_grad_vars);
}
VLOG(1) << " in eager_api_run_partial_grad, after runing egr::Grad";
return ToPyObject(result, true /* return_py_none_if_not_initialize */);
EAGER_CATCH_AND_THROW_RETURN_NULL
......@@ -179,6 +185,8 @@ static PyObject* eager_api_read_next_tensor_list(PyObject* self,
auto tensor_base_list =
CastPyArg2VectorOfTensorBase(PyTuple_GET_ITEM(args, 0), 0);
std::vector<paddle::experimental::Tensor> tensor_list;
{
eager_gil_scoped_release guard;
tensor_list.reserve(tensor_base_list.size());
auto func = [](framework::Tensor& tensor_base) {
paddle::experimental::Tensor tensor(
......@@ -192,6 +200,7 @@ static PyObject* eager_api_read_next_tensor_list(PyObject* self,
for (auto& tensor_base : tensor_base_list) {
tensor_list.emplace_back(func(tensor_base));
}
}
return ToPyObject(tensor_list);
EAGER_CATCH_AND_THROW_RETURN_NULL
}
......
......@@ -253,5 +253,17 @@ std::vector<paddle::framework::Scope*> GetScopePtrListFromArgs(
ssize_t arg_idx,
bool dispensable);
class eager_gil_scoped_release {
public:
eager_gil_scoped_release() { tstate = PyEval_SaveThread(); }
~eager_gil_scoped_release() {
if (!tstate) return;
PyEval_RestoreThread(tstate);
}
private:
PyThreadState* tstate{nullptr};
};
} // namespace pybind
} // namespace paddle
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册