From 3fbff1ee787bdcf9dd653fa7ea7f3e3732c5423f Mon Sep 17 00:00:00 2001
From: sweetsky0901 <work@yq01-idl-gpu-online20.yq01.baidu.com>
Date: Mon, 20 Nov 2017 16:41:14 +0800
Subject: [PATCH] for code review 5

---
 paddle/operators/math/maxouting.cc | 1 +
 paddle/operators/math/maxouting.cu | 1 +
 paddle/operators/maxout_op.cu.cc   | 5 +++++
 3 files changed, 7 insertions(+)

diff --git a/paddle/operators/math/maxouting.cc b/paddle/operators/math/maxouting.cc
index c8c1974f79a..bcd4da612c8 100644
--- a/paddle/operators/math/maxouting.cc
+++ b/paddle/operators/math/maxouting.cc
@@ -89,6 +89,7 @@ public:
               if (input_data[input_idx] == output_data[output_idx]) {
                 input_grad_data[input_idx] += output_grad_data[output_idx];
                 continue_match = false;
+                break;
               }
           }
         }
diff --git a/paddle/operators/math/maxouting.cu b/paddle/operators/math/maxouting.cu
index 3a0600fd846..0a8afbbaca3 100644
--- a/paddle/operators/math/maxouting.cu
+++ b/paddle/operators/math/maxouting.cu
@@ -65,6 +65,7 @@ __global__ void KernelMaxoutGrad(
         if (input_data[data_idx + g * feat_len] == output_data[i]) {
           max_index = data_idx + g * feat_len;
           continue_match = false;
+          break;
         }
       }
       if (max_index != -1) {
diff --git a/paddle/operators/maxout_op.cu.cc b/paddle/operators/maxout_op.cu.cc
index 3e6debf6996..5ee431cb26c 100644
--- a/paddle/operators/maxout_op.cu.cc
+++ b/paddle/operators/maxout_op.cu.cc
@@ -17,6 +17,11 @@
 namespace ops = paddle::operators;
 REGISTER_OP_GPU_KERNEL(maxout, ops::MaxOutKernel<paddle::platform::GPUPlace,
                        float>);
+REGISTER_OP_GPU_KERNEL(maxout, ops::MaxOutKernel<paddle::platform::GPUPlace,
+                       double>);
 REGISTER_OP_GPU_KERNEL(maxout_grad,
                        ops::MaxOutGradKernel<paddle::platform::GPUPlace,
                        float>);
+REGISTER_OP_GPU_KERNEL(maxout_grad,
+                       ops::MaxOutGradKernel<paddle::platform::GPUPlace,
+                       double>);
-- 
GitLab