From 3957007c754d784212808180e064f32ec5834f74 Mon Sep 17 00:00:00 2001 From: gouzil <66515297+gouzil@users.noreply.github.com> Date: Tue, 28 Mar 2023 10:47:04 +0800 Subject: [PATCH] [CodeStyle][B015] replace pointless comparisons with appropriate statements (#52126) * [CodeStyle][B015] delete unused * [CodeStyle][B015] add assert --- pyproject.toml | 2 +- .../fluid/tests/unittests/auto_parallel/test_dist_assign.py | 3 +-- .../fluid/tests/unittests/auto_parallel/test_dist_scale.py | 4 ++-- .../fluid/tests/unittests/auto_parallel/test_dist_shape.py | 4 ++-- python/paddle/fluid/tests/unittests/test_clip_op.py | 2 +- 5 files changed, 7 insertions(+), 8 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 68887b9df08..15999a33350 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -100,7 +100,7 @@ select = [ "B012", "B013", "B014", - # "B015", + "B015", "B016", # "B017", "B018", diff --git a/python/paddle/fluid/tests/unittests/auto_parallel/test_dist_assign.py b/python/paddle/fluid/tests/unittests/auto_parallel/test_dist_assign.py index eb9117772b3..87064a45a49 100644 --- a/python/paddle/fluid/tests/unittests/auto_parallel/test_dist_assign.py +++ b/python/paddle/fluid/tests/unittests/auto_parallel/test_dist_assign.py @@ -65,8 +65,7 @@ class TestDistAssign(unittest.TestCase): for op in ops: if op.type == "assign": dist_op = dist_context.get_dist_op_for_program(op) - dist_op.dist_attr.impl_type == "assign" - dist_op.dist_attr.impl_idx == 0 + assert dist_op.dist_attr.impl_type == "assign" x_name = op.input_arg_names[0] out_name = op.output_arg_names[0] diff --git a/python/paddle/fluid/tests/unittests/auto_parallel/test_dist_scale.py b/python/paddle/fluid/tests/unittests/auto_parallel/test_dist_scale.py index 2bee2285b58..b68131e361e 100644 --- a/python/paddle/fluid/tests/unittests/auto_parallel/test_dist_scale.py +++ b/python/paddle/fluid/tests/unittests/auto_parallel/test_dist_scale.py @@ -60,8 +60,8 @@ class TestDistScale(unittest.TestCase): ops = dist_main_prog.global_block().ops scale_op = ops[0] dist_op = dist_context.get_dist_op_for_program(scale_op) - dist_op.dist_attr.impl_type == "scale" - dist_op.dist_attr.impl_idx == 0 + assert dist_op.dist_attr.impl_type == "scale" + assert dist_op.dist_attr.impl_idx == 0 in_name = scale_op.input_arg_names[0] out_name = scale_op.output_arg_names[0] diff --git a/python/paddle/fluid/tests/unittests/auto_parallel/test_dist_shape.py b/python/paddle/fluid/tests/unittests/auto_parallel/test_dist_shape.py index 5c4ecfcfabb..0322a817934 100644 --- a/python/paddle/fluid/tests/unittests/auto_parallel/test_dist_shape.py +++ b/python/paddle/fluid/tests/unittests/auto_parallel/test_dist_shape.py @@ -60,8 +60,8 @@ class TestDistShape(unittest.TestCase): ops = dist_main_prog.global_block().ops shape_op = ops[0] dist_op = dist_context.get_dist_op_for_program(shape_op) - dist_op.dist_attr.impl_type == "shape" - dist_op.dist_attr.impl_idx == 0 + assert dist_op.dist_attr.impl_type == "shape" + assert dist_op.dist_attr.impl_idx == 0 in_name = shape_op.input_arg_names[0] out_name = shape_op.output_arg_names[0] diff --git a/python/paddle/fluid/tests/unittests/test_clip_op.py b/python/paddle/fluid/tests/unittests/test_clip_op.py index 9b6ddcee80e..979ce6e7cc9 100644 --- a/python/paddle/fluid/tests/unittests/test_clip_op.py +++ b/python/paddle/fluid/tests/unittests/test_clip_op.py @@ -113,7 +113,7 @@ class TestCase5(TestClipOp): class TestCase6(TestClipOp): def initTestCase(self): - self.dtype == np.float16 + self.dtype = np.float16 self.shape = (4, 8, 8) self.max = 0.7 self.min = 0.2 -- GitLab