From 2b7aca25f9c2aeab2bb6bd2669cd802c7a531b60 Mon Sep 17 00:00:00 2001 From: Zeng Jinle <32832641+sneaxiy@users.noreply.github.com> Date: Fri, 27 Sep 2019 20:18:38 +0800 Subject: [PATCH] add xiaoguang as API.spec approver, test=develop, test=document_fix (#20057) --- tools/check_api_approvals.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/check_api_approvals.sh b/tools/check_api_approvals.sh index 2ccc48255a7..d56ae23a1b8 100644 --- a/tools/check_api_approvals.sh +++ b/tools/check_api_approvals.sh @@ -49,7 +49,7 @@ for API_FILE in ${API_FILES[*]}; do # NOTE: per_page=10000 should be ok for all cases, a PR review > 10000 is not human readable. # approval_user_list: XiaoguangHu01 46782768,chengduoZH 30176695,Xreki 12538138,luotao1 6836917,sneaxiy 32832641,tensor-tang 21351065,xsrobin 50069408,qingqing01 7845005,guoshengCS 14105589,heavengate 12605721,kuke 3064195,Superjomn 328693,lanxianghit 47554610,cyj1986 39645414,hutuxian 11195205,frankwhzhang 20274488,nepeplwu 45024560,Dianhai 38231817,JiabinYang 22361972,chenwhql 22561442. if [ "${API_FILE}" == "paddle/fluid/API.spec" ];then - APPROVALS=`echo ${approval_line}|python ${PADDLE_ROOT}/tools/check_pr_approval.py 2 7534971 14105589 12605721 3064195 328693 47554610 39645414 11195205 20274488 45024560 ` + APPROVALS=`echo ${approval_line}|python ${PADDLE_ROOT}/tools/check_pr_approval.py 2 46782768 7534971 14105589 12605721 3064195 328693 47554610 39645414 11195205 20274488 45024560 ` elif [ "${API_FILE}" == "paddle/fluid/op_use_default_grad_op_maker.spec" ];then APPROVALS=`echo ${approval_line}|python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 32832641 6836917` elif [ "${API_FILE}" == "CMakeLists.txt" ];then @@ -65,7 +65,7 @@ for API_FILE in ${API_FILES[*]}; do if [ "${APPROVALS}" == "FALSE" ]; then if [ "${API_FILE}" == "paddle/fluid/API.spec" ];then failed_num=`expr $failed_num + 1` - echo_line="You must have two RD (wanghaoshuang or guoshengCS or heavengate or kuke or Superjomn or lanxianghit or cyj1986 or hutuxian or frankwhzhang or nepeplwu) approval for the api change! ${API_FILE} for the management reason of API interface and API document.\n" + echo_line="You must have two RD (XiaoguangHu01 or wanghaoshuang or guoshengCS or heavengate or kuke or Superjomn or lanxianghit or cyj1986 or hutuxian or frankwhzhang or nepeplwu) approval for the api change! ${API_FILE} for the management reason of API interface and API document.\n" echo_list=(${echo_list[@]}$failed_num "." $echo_line) elif [ "${API_FILE}" == "paddle/fluid/op_use_default_grad_op_maker.spec" ];then failed_num=`expr $failed_num + 1` -- GitLab