From 287de41c04c8fb74d4e7ced913d57cf89d282d21 Mon Sep 17 00:00:00 2001 From: Qiao Longfei Date: Mon, 20 May 2019 23:09:20 +0800 Subject: [PATCH] Optimize communicator flags (#17494) * optimize communicator flag * change flags in init py test=develop --- paddle/fluid/operators/distributed/communicator.cc | 8 ++++---- python/paddle/fluid/__init__.py | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/paddle/fluid/operators/distributed/communicator.cc b/paddle/fluid/operators/distributed/communicator.cc index b528bcdd32b..6e1015d320b 100644 --- a/paddle/fluid/operators/distributed/communicator.cc +++ b/paddle/fluid/operators/distributed/communicator.cc @@ -29,7 +29,7 @@ DEFINE_bool(communicator_independent_recv_thread, true, "use an independent to recv vars from parameter server"); DEFINE_int32(communicator_send_queue_size, 20, "queue size to recv gradient before send"); -DEFINE_int32(communicator_max_send_grad_num_before_recv, 20, +DEFINE_int32(communicator_min_send_grad_num_before_recv, 20, "max grad num to send before recv parameters"); DEFINE_int32(communicator_thread_pool_size, 5, "thread num to do send or recv"); DEFINE_int32(communicator_send_wait_times, 5, @@ -64,8 +64,8 @@ Communicator::Communicator(const RpcCtxMap &send_varname_to_ctx, << FLAGS_communicator_independent_recv_thread; VLOG(0) << "communicator_send_queue_size: " << FLAGS_communicator_send_queue_size; - VLOG(0) << "communicator_max_send_grad_num_before_recv: " - << FLAGS_communicator_max_send_grad_num_before_recv; + VLOG(0) << "communicator_min_send_grad_num_before_recv: " + << FLAGS_communicator_min_send_grad_num_before_recv; VLOG(0) << "communicator_thread_pool_size: " << FLAGS_communicator_thread_pool_size; VLOG(0) << "communicator_send_wait_times: " @@ -189,7 +189,7 @@ void Communicator::RecvThread() { VLOG(3) << "RecvThread start!"; while (running_) { auto grad_num = grad_num_.load(); - if (grad_num > FLAGS_communicator_max_send_grad_num_before_recv) { + if (grad_num > FLAGS_communicator_min_send_grad_num_before_recv) { VLOG(1) << "current grad num " << grad_num; RecvAll(); grad_num_.store(0); diff --git a/python/paddle/fluid/__init__.py b/python/paddle/fluid/__init__.py index 00804cf35bc..71ad2f0cf0b 100644 --- a/python/paddle/fluid/__init__.py +++ b/python/paddle/fluid/__init__.py @@ -167,7 +167,7 @@ def __bootstrap__(): # env for communicator read_env_flags.append('communicator_independent_recv_thread') read_env_flags.append('communicator_send_queue_size') - read_env_flags.append('communicator_max_send_grad_num_before_recv') + read_env_flags.append('communicator_min_send_grad_num_before_recv') read_env_flags.append('communicator_thread_pool_size') read_env_flags.append('communicator_max_merge_var_num') read_env_flags.append('communicator_fake_rpc') -- GitLab