From 1cc68c3fe645947bbe0591f3625fc405fa0ddfdf Mon Sep 17 00:00:00 2001 From: Zeng Jinle <32832641+sneaxiy@users.noreply.github.com> Date: Tue, 15 Oct 2019 14:23:13 +0800 Subject: [PATCH] fix check_api_approval.sh, test=develop, test=document_fix (#20632) --- tools/check_api_approvals.sh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/check_api_approvals.sh b/tools/check_api_approvals.sh index e26fa58def1..a366ab9ac32 100644 --- a/tools/check_api_approvals.sh +++ b/tools/check_api_approvals.sh @@ -44,9 +44,11 @@ fi api_spec_diff=`python ${PADDLE_ROOT}/tools/diff_api.py ${PADDLE_ROOT}/paddle/fluid/API_DEV.spec ${PADDLE_ROOT}/paddle/fluid/API_PR.spec` if [ "$api_spec_diff" != "" ]; then APPROVALS=`echo ${approval_line}|python ${PADDLE_ROOT}/tools/check_pr_approval.py 2 46782768 7534971 14105589 12605721 3064195 328693 47554610 39645414 11195205 20274488 45024560` - failed_num=`expr $failed_num + 1` - echo_line="You must have two RD (XiaoguangHu01 or wanghaoshuang or guoshengCS or heavengate or kuke or Superjomn or lanxianghit or cyj1986 or hutuxian or frankwhzhang or nepeplwu) approval for the api change for the management reason of API interface and API document." - echo_list=(${echo_list[@]}$failed_num "." $echo_line) + if [ "${APPROVALS}" == "FALSE" ]; then + failed_num=`expr $failed_num + 1` + echo_line="You must have two RD (XiaoguangHu01 or wanghaoshuang or guoshengCS or heavengate or kuke or Superjomn or lanxianghit or cyj1986 or hutuxian or frankwhzhang or nepeplwu) approval for the api change for the management reason of API interface and API document." + echo_list=(${echo_list[@]}$failed_num "." $echo_line) + fi fi for API_FILE in ${API_FILES[*]}; do -- GitLab