diff --git a/.clang-tidy b/.clang-tidy index 38957a23d1d3c02e4d5dcf87c733235d7ee41293..4f548de850ceb1d58ce1ed8f667ca9f61001c7da 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,6 +1,6 @@ --- Checks: ' --bugprone-argument-comment, +bugprone-argument-comment, -bugprone-assert-side-effect, -bugprone-bad-signal-to-kill-thread, -bugprone-bool-pointer-implicit-conversion, diff --git a/paddle/fluid/framework/executor_cache.cc b/paddle/fluid/framework/executor_cache.cc index 67646dec6db670058c3486230438e6bf7cb95056..eaa4c3ec0e5fcfa413e691140f7d10190b5bdeb3 100644 --- a/paddle/fluid/framework/executor_cache.cc +++ b/paddle/fluid/framework/executor_cache.cc @@ -266,7 +266,7 @@ CacheInfo GetExecutorInfoFromCache(const ProgramDesc &program_desc, auto &cached_value = cached_exe_info.GetMutable(program_id, is_grad); cached_value.executor_ = pe_and_graph.first; cached_value.graph_ = pe_and_graph.second; - return std::make_pair(pe_and_graph.first, /*is_new_created=*/true); + return std::make_pair(pe_and_graph.first, true); } else { VLOG(1) << "get exe_info from cache by: " << program_id << " is_grad: " << is_grad; @@ -280,7 +280,7 @@ CacheInfo GetExecutorInfoFromCache(const ProgramDesc &program_desc, // need to recreate tmp variables in new scope parallel_executor->PrepareVariables(scope); - return std::make_pair(parallel_executor, /*is_new_created=*/false); + return std::make_pair(parallel_executor, false); } } diff --git a/paddle/fluid/framework/new_executor/interpreter/stream_analyzer.cc b/paddle/fluid/framework/new_executor/interpreter/stream_analyzer.cc index 1ee621624dbfffe677fd6f2b83c853be468d305a..3fc9dde363039ac8ce4dab7eaf96a0cc1fc02995 100644 --- a/paddle/fluid/framework/new_executor/interpreter/stream_analyzer.cc +++ b/paddle/fluid/framework/new_executor/interpreter/stream_analyzer.cc @@ -58,8 +58,8 @@ void StreamAnalyzer::ConstructEvents(std::vector* instructions) { std::vector>> run_type_info( instr_num, std::vector>( - /*number_of_run_type = */ 2)); // instr_id -> run_type -> - // next_instr_id + /*number_of_run_type = */ 2)); // NOLINT + // instr_id -> run_type -> next_instr_id AnalyseAllRunType( cross_step_merged_instructions_ptr, downstream_map, &run_type_info); diff --git a/paddle/fluid/framework/parallel_executor.cc b/paddle/fluid/framework/parallel_executor.cc index 8477ee362e36d50b02d1c8adfd9d1dde6f907d1f..24832d206091158163817c2d017bb849a1362b85 100644 --- a/paddle/fluid/framework/parallel_executor.cc +++ b/paddle/fluid/framework/parallel_executor.cc @@ -754,7 +754,7 @@ ParallelExecutor::ParallelExecutor(const platform::Place &place, /*device_count=*/1, *graph); - CreateLocalScopes(scope, /*local_scope=*/{scope}, /*create_new=*/false); + CreateLocalScopes(scope, /*local_scopes=*/{scope}, /*create_new=*/false); // Apply BuildStrategy to compile graph. std::vector graphs = {graph};