From 06ef3f042b966785604d95eff03eeb014e543bce Mon Sep 17 00:00:00 2001 From: Chen Weihang Date: Tue, 25 Oct 2022 07:28:12 -0500 Subject: [PATCH] update phi approval list, test=document_fix (#47332) --- tools/check_file_diff_approvals.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/check_file_diff_approvals.sh b/tools/check_file_diff_approvals.sh index fc8cf7e768f..d2419e77220 100644 --- a/tools/check_file_diff_approvals.sh +++ b/tools/check_file_diff_approvals.sh @@ -299,8 +299,8 @@ for CHANGE_FILE in ${HAS_MODIFIED_PHI_FILES}; do fi done if [ "${PHI_INCLUDE_FLUID_FILES}" != "" ] && [ "${GIT_PR_ID}" != "" ]; then - echo_line="You must have one RD (chenwhql, MingMingShangTian, YuanRisheng or zyfncg) approval for the including paddle/fluid header in paddle/phi files(${PHI_INCLUDE_FLUID_FILES}).\n" - check_approval 1 chenwhql MingMingShangTian YuanRisheng zyfncg + echo_line="You must have one RD (chenwhql, YuanRisheng or zyfncg) approval for the including paddle/fluid header in paddle/phi files(${PHI_INCLUDE_FLUID_FILES}).\n" + check_approval 1 chenwhql YuanRisheng zyfncg fi HAS_MODIFIED_PHI_KERNEL_FILES=`git diff --name-only upstream/$BRANCH | grep "paddle/phi/kernels" || true` @@ -312,8 +312,8 @@ for CHANGE_FILE in ${HAS_MODIFIED_PHI_KERNEL_FILES}; do fi done if [ "${PHI_USE_MUTABLE_DATA_FILES}" != "" ] && [ "${GIT_PR_ID}" != "" ]; then - echo_line="You can not use the DenseTensor::mutable_data() method in paddle/phi/kernels files(${PHI_USE_MUTABLE_DATA_FILES}). If you want to alloc memory, use phi::DeviceContext::Alloc() or phi::DeviceContext::HostAlloc() instead and if you want to get mutable data, use DenseTensor::data(). If you have any questions, you can have one RD (chenwhql, Shixiaowei02, MingMingShangTian, YuanRisheng or zyfncg) review and approve.\n" - check_approval 1 chenwhql Shixiaowei02 MingMingShangTian YuanRisheng zyfncg + echo_line="You can not use the DenseTensor::mutable_data() method in paddle/phi/kernels files(${PHI_USE_MUTABLE_DATA_FILES}). If you want to alloc memory, use phi::DeviceContext::Alloc() or phi::DeviceContext::HostAlloc() instead and if you want to get mutable data, use DenseTensor::data(). If you have any questions, you can have one RD (chenwhql, Shixiaowei02, YuanRisheng or zyfncg) review and approve.\n" + check_approval 1 chenwhql Shixiaowei02 YuanRisheng zyfncg fi ALL_CHANGE_FILES=`git diff --numstat upstream/$BRANCH | awk '{print $3}' | grep ".py"` -- GitLab