From 035d185f7ca452b5062ebb37f24c44672d8fc106 Mon Sep 17 00:00:00 2001 From: Aurelius84 Date: Wed, 16 Aug 2023 13:59:54 +0800 Subject: [PATCH] [Approve]Modify inference size approve name list (#56332) * [Approve]Modify inference size approve name list --- paddle/scripts/paddle_build.sh | 4 ++-- tools/check_api_approvals.sh | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/paddle/scripts/paddle_build.sh b/paddle/scripts/paddle_build.sh index 5a665db8ba9..c2cb5b105ef 100644 --- a/paddle/scripts/paddle_build.sh +++ b/paddle/scripts/paddle_build.sh @@ -1156,12 +1156,12 @@ function check_approvals_of_unittest() { EOF if [ $(awk "BEGIN{print 20<$AllDiffSize}") -eq 1 ] ; then approval_line=`curl -H "Authorization: token ${GITHUB_API_TOKEN}" https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID}/reviews?per_page=10000` - APPROVALS=`echo ${approval_line}|python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 39303645 7845005 26377421` + APPROVALS=`echo ${approval_line}|python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 89012307 7845005 23653004` echo "current pr ${GIT_PR_ID} got approvals: ${APPROVALS}" if [ "${APPROVALS}" == "FALSE" ]; then echo "==========================================================================================" echo "This PR make the release inference library size growth exceeds 20 M." - echo "Then you must have one RD (jiweibo (Recommend), qingqing01 or Shixiaowei02) approval for this PR\n" + echo "Then you must have one RD (vivienfanghuagood (Recommend), qingqing01 or yuanlehome) approval for this PR\n" echo "==========================================================================================" exit 6 fi diff --git a/tools/check_api_approvals.sh b/tools/check_api_approvals.sh index 0cd1dd927d8..be25f04368d 100644 --- a/tools/check_api_approvals.sh +++ b/tools/check_api_approvals.sh @@ -94,8 +94,8 @@ op_desc_diff=`python ${PADDLE_ROOT}/tools/check_op_desc.py ${PADDLE_ROOT}/paddle inference_approve=`echo "$op_desc_diff" | grep "need inference to review" -` slim_approve=`echo "$op_desc_diff" | grep "need slim to review" -` if [ "$op_desc_diff" != "" ]; then - echo_line="You must have one RD (inference[ qingqing01(Recommend), jiweibo, cyj1986 ] or slim[ wanghaoshuang(Recommend), qingqing01 ] or train[ chenwhql(Recommend), phlrain ]) approval for the changes of Inputs/Output/Attrs of OPs. The changes of OPs will cause that the new version inference fails to load model trained by the old version. Please modify your code. \n For more details, please click [https://github.com/PaddlePaddle/Paddle/wiki/OP-Input-Output-Attribute-Compatibility-Modification].\n${op_desc_diff}\n" - check_approval 1 39645414 7534971 7845005 22561442 43953930 26377421 + echo_line="You must have one RD (inference[ vivienfanghuagood(Recommend), yuanlehome, qingqing01 ] or slim[ wanghaoshuang(Recommend), qingqing01 ] or train[ chenwhql(Recommend), phlrain ]) approval for the changes of Inputs/Output/Attrs of OPs. The changes of OPs will cause that the new version inference fails to load model trained by the old version. Please modify your code. \n For more details, please click [https://github.com/PaddlePaddle/Paddle/wiki/OP-Input-Output-Attribute-Compatibility-Modification].\n${op_desc_diff}\n" + check_approval 1 vivienfanghuagood yuanlehome qingqing01 wanghaoshuang chenwhql phlrain fi if [ "$slim_approve" != "" ]; then -- GitLab