service.go 6.2 KB
Newer Older
1 2 3 4
package master

import (
	"errors"
5 6
	"os"
	"path/filepath"
7 8 9
	"sync"
	"time"

H
Helin Wang 已提交
10 11
	log "github.com/sirupsen/logrus"

12
	"github.com/PaddlePaddle/recordio"
13 14 15 16
)

// Service is the master server service.
type Service struct {
17 18 19 20
	chunksPerTask int
	timeoutDur    time.Duration
	timeoutMax    int
	ready         chan struct{}
21 22

	mu         sync.Mutex
H
Helin Wang 已提交
23
	initDone   bool
24 25 26 27 28 29 30 31 32
	taskQueues taskQueues
}

// Recover recovers service state from etcd.
func Recover() (*Service, error) {
	// TODO(helin): recover from snapshot state from etcd.
	return nil, nil
}

H
Helin Wang 已提交
33
func partition(chunks []Chunk, chunksPerTask int) []taskEntry {
34
	id := 0
H
Helin Wang 已提交
35 36
	if chunksPerTask <= 0 {
		chunksPerTask = 1
37 38 39 40 41
	}

	var result []taskEntry
	var cur taskEntry
	for i, c := range chunks {
H
Helin Wang 已提交
42
		if i%chunksPerTask == 0 && len(cur.Task.Chunks) > 0 {
43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60
			cur.Task.ID = id
			id++
			result = append(result, cur)
			cur.Task.Chunks = nil
		}

		cur.Task.Chunks = append(cur.Task.Chunks, c)
	}

	if len(cur.Task.Chunks) > 0 {
		cur.Task.ID = id
		result = append(result, cur)
	}

	return result
}

// NewService creates a new service.
61
func NewService(chunksPerTask int, timeoutDur time.Duration, timeoutMax int) *Service {
62
	s := &Service{}
63
	s.chunksPerTask = chunksPerTask
64 65 66 67
	s.timeoutDur = timeoutDur
	s.timeoutMax = timeoutMax
	s.taskQueues = taskQueues{}
	s.taskQueues.Pending = make(map[int]taskEntry)
68
	s.ready = make(chan struct{})
H
Helin Wang 已提交
69
	return s
70 71 72 73 74
}

// Chunk is a chunk of data consisted of several data instances.
type Chunk struct {
	Path  string
75
	Index recordio.Index // chunk index
76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102
}

// Task is the basic unit of data instances assigned to trainers.
type Task struct {
	ID     int
	Chunks []Chunk
}

type taskEntry struct {
	Epoch      int
	NumTimeout int
	Task       Task
}

type taskQueues struct {
	Todo    []taskEntry
	Pending map[int]taskEntry // map from task ID to task entry
	Done    []taskEntry
	Failed  []Task
}

// *must* be called with s.mu being held.
func (s *Service) snapshot() error {
	// TODO(helin): snapshot state on etcd.
	return nil
}

H
Helin Wang 已提交
103
func readChunks(globPaths []string) ([]Chunk, error) {
104 105 106 107 108 109
	var chunks []Chunk
	var paths []string

	for _, s := range globPaths {
		match, err := filepath.Glob(s)
		if err != nil {
H
Helin Wang 已提交
110
			return nil, err
111 112 113 114 115
		}
		paths = append(paths, match...)
	}

	if len(paths) == 0 {
H
Helin Wang 已提交
116
		return nil, errors.New("no valid dataset specified")
117 118 119 120 121
	}

	for _, path := range paths {
		f, err := os.Open(path)
		if err != nil {
H
Helin Wang 已提交
122
			return nil, err
123 124 125 126
		}

		index, err := recordio.LoadIndex(f)
		if err != nil {
H
Helin Wang 已提交
127
			return nil, err
128 129 130
		}
		err = f.Close()
		if err != nil {
H
Helin Wang 已提交
131
			return nil, err
132 133 134 135 136 137 138 139 140 141 142 143
		}

		count := index.NumChunks()
		for i := 0; i < count; i++ {
			chunk := Chunk{
				Path:  path,
				Index: *index.ChunkIndex(i),
			}
			chunks = append(chunks, chunk)
		}
	}

H
Helin Wang 已提交
144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164
	return chunks, nil
}

// SetDataset sets dataset to dispatch for the master server.
//
// SetDataset can be call multiple times. But only the first call will
// be honored.
func (s *Service) SetDataset(globPaths []string, dummy *int) error {
	if len(globPaths) == 0 {
		return errors.New("no dataset specified")
	}

	s.mu.Lock()
	defer s.mu.Unlock()
	if s.initDone {
		// Already initialized. All trainer will call
		// SetDataset, but we only handle the first one. Treat
		// other calls as successful but do nothing.
		return nil
	}

H
Helin Wang 已提交
165
	chunks, err := readChunks(globPaths)
H
Helin Wang 已提交
166 167 168 169
	if err != nil {
		return err
	}

170 171
	s.taskQueues.Todo = partition(chunks, s.chunksPerTask)

H
Helin Wang 已提交
172
	err = s.snapshot()
173
	if err != nil {
H
Helin Wang 已提交
174
		log.Errorln(err)
175 176 177 178
		return err
	}

	close(s.ready)
H
Helin Wang 已提交
179
	s.initDone = true
180 181 182
	return nil
}

H
Helin Wang 已提交
183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219
func (s *Service) checkTimeoutFunc(taskID int, epoch int) func() {
	return func() {
		s.mu.Lock()
		defer s.mu.Unlock()

		t, ok := s.taskQueues.Pending[taskID]
		if !ok {
			return
		}

		if t.Epoch != epoch {
			// new epoch, task launched after the
			// schedule of this timeout check.
			return
		}

		defer func() {
			err := s.snapshot()
			if err != nil {
				log.Errorln(err)
			}
		}()

		delete(s.taskQueues.Pending, t.Task.ID)

		t.NumTimeout++
		if t.NumTimeout > s.timeoutMax {
			log.Warningf("Task %v failed %d times, discard.\n", t.Task, t.NumTimeout)
			s.taskQueues.Failed = append(s.taskQueues.Failed, t.Task)
			return
		}

		log.Warningf("Task %v failed %d times, retry.\n", t.Task, t.NumTimeout)
		s.taskQueues.Todo = append(s.taskQueues.Todo, t)
	}
}

220 221
// GetTask gets a new task from the service.
func (s *Service) GetTask(dummy int, task *Task) error {
222 223 224 225
	select {
	case <-s.ready:
	}

226 227 228 229
	s.mu.Lock()
	defer s.mu.Unlock()

	if len(s.taskQueues.Todo) == 0 {
230 231
		if len(s.taskQueues.Done) == 0 {
			if len(s.taskQueues.Pending) == 0 {
H
Helin Wang 已提交
232 233 234
				err := errors.New("all task failed")
				log.Warningln(err)
				return err
235 236 237 238 239
			}

			// TODO(helin): client need to retry in this
			// error case. Gotcha: RPC client can't
			// compare returned error with predefined
H
Helin Wang 已提交
240
			// errors like io.EOF, because interface don't
241
			// have same dynamic value when in different
H
Helin Wang 已提交
242 243 244 245 246
			// process. So we need to figure out a way for
			// client to check this error correctly.
			err := errors.New("no more available task")
			log.Warningln(err)
			return err
247 248
		}
		s.taskQueues.Todo = s.taskQueues.Done
H
Helin Wang 已提交
249 250
		s.taskQueues.Done = nil
		log.Infoln("No more todo task, but trainer is requesting task to do. Move all done task to todo.")
251 252 253 254 255 256 257 258 259 260 261
	}

	t := s.taskQueues.Todo[0]
	t.Epoch++
	s.taskQueues.Todo = s.taskQueues.Todo[1:]
	s.taskQueues.Pending[t.Task.ID] = t
	err := s.snapshot()
	if err != nil {
		return err
	}

262
	*task = t.Task
H
Helin Wang 已提交
263
	log.Infof("Task #%d dispatched\n", task.ID)
264

H
Helin Wang 已提交
265
	time.AfterFunc(s.timeoutDur, s.checkTimeoutFunc(t.Task.ID, t.Epoch))
266 267 268 269 270
	return nil
}

// TaskFinished tell the service that a task is finished.
func (s *Service) TaskFinished(taskID int, dummy *int) error {
271 272 273 274
	select {
	case <-s.ready:
	}

275 276 277
	s.mu.Lock()
	defer s.mu.Unlock()

H
Helin Wang 已提交
278 279
	log.Infof("Task %d finished\n", taskID)

280 281
	t, ok := s.taskQueues.Pending[taskID]
	if !ok {
H
Helin Wang 已提交
282 283 284
		err := errors.New("pending task not found")
		log.Warningln(err)
		return err
285 286 287 288 289 290
	}

	// task finished, reset timeout
	t.NumTimeout = 0
	s.taskQueues.Done = append(s.taskQueues.Done, t)
	delete(s.taskQueues.Pending, taskID)
291

H
Helin Wang 已提交
292 293
	if len(s.taskQueues.Pending) == 0 && len(s.taskQueues.Todo) == 0 {
		log.Infoln("No more todo and pending task, start a new pass.")
294
		s.taskQueues.Todo = append(s.taskQueues.Todo, s.taskQueues.Done...)
295 296 297
		s.taskQueues.Done = nil
	}

H
Helin Wang 已提交
298 299 300 301 302
	err := s.snapshot()
	if err != nil {
		log.Errorln(err)
	}
	return err
303
}