From bc2ab233eeb6d316f6a27a4d9e7e59357c03d93b Mon Sep 17 00:00:00 2001 From: teaguecl Date: Fri, 25 Jan 2019 21:51:25 -0800 Subject: [PATCH] Fix error in example_1 and example_2 This test case had an error in both examples: test_FindFunction_WhichIsBroken_ShouldReturnZeroIfItemIsNotInList_WhichWorksEvenInOurBrokenCode It was supposed to be a list of values that are NOT in the list, and none of them should be found. It incorrectly included '1' --- examples/example_1/makefile | 1 - examples/example_2/test/TestProductionCode.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/examples/example_1/makefile b/examples/example_1/makefile index ee0cf73..cca79b4 100644 --- a/examples/example_1/makefile +++ b/examples/example_1/makefile @@ -41,7 +41,6 @@ CFLAGS += -Wno-unknown-pragmas CFLAGS += -Wstrict-prototypes CFLAGS += -Wundef CFLAGS += -Wold-style-definition -CFLAGS += -Wno-misleading-indentation TARGET_BASE1=test1 TARGET_BASE2=test2 diff --git a/examples/example_2/test/TestProductionCode.c b/examples/example_2/test/TestProductionCode.c index ff318ab..b8fb95c 100644 --- a/examples/example_2/test/TestProductionCode.c +++ b/examples/example_2/test/TestProductionCode.c @@ -23,7 +23,7 @@ TEST(ProductionCode, FindFunction_WhichIsBroken_ShouldReturnZeroIfItemIsNotInLis { //All of these should pass TEST_ASSERT_EQUAL(0, FindFunction_WhichIsBroken(78)); - TEST_ASSERT_EQUAL(0, FindFunction_WhichIsBroken(1)); + TEST_ASSERT_EQUAL(0, FindFunction_WhichIsBroken(2)); TEST_ASSERT_EQUAL(0, FindFunction_WhichIsBroken(33)); TEST_ASSERT_EQUAL(0, FindFunction_WhichIsBroken(999)); TEST_ASSERT_EQUAL(0, FindFunction_WhichIsBroken(-1)); -- GitLab