From 63db6b772fa264a62927f6a3584733192dc5a352 Mon Sep 17 00:00:00 2001 From: Richard Levitte Date: Wed, 24 Aug 2016 12:46:09 +0200 Subject: [PATCH] Trust RSA_check_key() to return correct values In apps/rsa.c, we were second guessing RSA_check_key() to leave error codes lying around without returning -1 properly. However, this also catches other errors that are lying around and that we should not care about. Reviewed-by: Rich Salz --- apps/rsa.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/apps/rsa.c b/apps/rsa.c index f67387e27f..bd2f53a6f4 100644 --- a/apps/rsa.c +++ b/apps/rsa.c @@ -230,10 +230,7 @@ int rsa_main(int argc, char **argv) ERR_reason_error_string(err)); ERR_get_error(); /* remove e from error stack */ } - } - - /* should happen only if r == -1 */ - if (r == -1 || ERR_peek_error() != 0) { + } else if (r == -1) { ERR_print_errors(bio_err); goto end; } -- GitLab