1. 30 1月, 2017 2 次提交
    • R
      avoid unbounded strlen in gettext functions · d6601f0a
      Rich Felker 提交于
      use the standard strnlen idiom for cases where lengths greater than an
      imposed limit are going to be rejected immediately anyway.
      d6601f0a
    • R
      fix use of uninitialized pointer in gettext core · dbbb3734
      Rich Felker 提交于
      the plural_rule field of allocated msgcat structures was assumed to be
      initially-null but was never initialized. for future-proofing, the
      nplurals field which was left uninitialized should also be cleared.
      
      likewise, in the binding structure, the active field could be used
      uninitialized by a technicality: the a_store which stores the initial
      value of 0 may be implemented as a cas operation, which reads the old
      value.
      
      rather than fixing these issues individually, just use calloc for both
      allocations. this does result in wasteful clearing of name buffers (up
      to NAME_MAX+PATH_MAX) before filling them, but since the size if
      bounded and the time is dominated by filesystem operations, it really
      doesn't matter; simplicity and future-proofing have more value here.
      
      modified from patch submitted by He X.
      dbbb3734
  2. 29 1月, 2017 1 次提交
  3. 20 1月, 2017 1 次提交
    • R
      fix spurious EINTR errors from multithreaded set*id, etc. · 6894f847
      Rich Felker 提交于
      commit 78a8ef47 inadvertently removed
      the SA_RESTART flag from the sigaction for the internal signal handler
      used by __synccall for broadcasting. as a result, programs which did
      not use interrupting signals but which used set*id() in a
      multithreaded context could wrongly observe EINTR errors they're not
      prepared to handle.
      6894f847
  4. 13 1月, 2017 1 次提交
    • R
      fix crashes in x32 __tls_get_addr · 1f53e7d0
      rofl0r 提交于
      x32 has another gratuitous difference to all other archs:
      it passes an array of 64bit values to __tls_get_addr().
      usually it is an array of size_t.
      1f53e7d0
  5. 05 1月, 2017 4 次提交
    • R
      fix crash from corrupted tls module list after failed dlopen · 27b3fd68
      Rich Felker 提交于
      commit d56460c9 introduced this
      regression as part of splitting the tls module list out of the dso
      list. the new code added to dlopen's failure path to undo the changes
      adding the partially-loaded libraries reset the tls_tail pointer
      correctly, but did not clear its link to the next list entry. thus, at
      least until the next successful dlopen, the list was not terminated
      but ended with an invalid next pointer, which __copy_tls attempted to
      follow when a new thread was created.
      
      patch by Mikael Vidstedt.
      27b3fd68
    • R
      treat base 1 as an error in strtol-family functions · 809ff8cf
      Rich Felker 提交于
      ISO C and POSIX only specify behavior for base arguments of 0 and
      2-36; POSIX mandates an EINVAL error for unsupported bases. it's not
      clear that there's a requirement for implementations not to "support"
      additional bases as an extension, but "base 1" did not work in any
      meaningful way anyway, so it should be considered unsupported and thus
      an error.
      809ff8cf
    • R
      fix getopt[_long] clobbering of optopt on success · 786fda87
      Rich Felker 提交于
      getopt is only specified to modify optopt on error, and some software
      apparently infers an error from optopt!=0.
      
      getopt_long is changed analogously. the resulting behavior differs
      slightly from the behavior of the GNU implementation of getopt_long,
      which keeps an internal shadow copy of optopt and copies it to the
      public one on return, but since the GNU implementation also exhibits
      this shadow-copy behavior for plain getopt where is is non-conforming,
      I think this can reasonably be considered a bug rather than an
      intentional behavior that merits mimicing.
      786fda87
    • R
      reduce impact of REG_* namespace pollution in x86[_64] signal.h · 150747b4
      Rich Felker 提交于
      when _GNU_SOURCE is defined, which is always the case when compiling
      c++ with gcc, these macros for the the indices in gregset_t are
      exposed and likely to clash with applications. by using enum constants
      rather than macros defined with integer literals, we can make the
      clash slightly less likely to break software. the macros are still
      defined in case anything checks for them with #ifdef, but they're
      defined to expand to themselves so that non-file-scope (e.g.
      namespaced) identifiers by the same names still work.
      
      for the sake of avoiding mistakes, the changes were generated with sed
      via the command:
      
      sed -i -e 's/#define  *\(REG_[A-Z_0-9]\{1,\}\)  *\([0-9]\{1,\}\)'\
      '/enum { \1 = \2 };\n#define \1 \1/' \
      arch/i386/bits/signal.h arch/x86_64/bits/signal.h arch/x32/bits/signal.h
      150747b4
  6. 03 1月, 2017 2 次提交
    • R
      make globfree safe after failed glob from over-length argument · 769f5359
      Rich Felker 提交于
      commit 0dc99ac4 added input length
      checking to avoid unsafe VLA allocation, but put it in the wrong
      place, before the glob_t structure was zeroed out. while POSIX isn't
      clear on whether it's permitted to call globfree after glob failed
      with GLOB_NOSPACE, making it safe is clearly better than letting
      uninitialized pointers get passed to free in non-conforming callers.
      
      while we're fixing this, change strlen check to the idiomatic strnlen
      version to avoid unbounded input scanning before returning an error.
      769f5359
    • R
      fix strftime %y for negative years · 61fb81e3
      Rich Felker 提交于
      commit 583ea835 fixed the case where
      tm_year is negative but the resulting year (offset by 1900) was still
      positive, which is always the case for time_t values that fit in 32
      bits, but not for arbitrary inputs.
      
      based on an earlier patch by Julien Ramseier which was overlooked at
      the time the previous fix was applied.
      61fb81e3
  7. 01 1月, 2017 1 次提交
  8. 30 12月, 2016 3 次提交
  9. 21 12月, 2016 1 次提交
    • R
      fix support for initialized TLS in static PIE binaries · 5bf7eba2
      Rich Felker 提交于
      the static-linked version of __init_tls needs to locate the TLS
      initialization image via the ELF program headers, which requires
      determining the base address at which the program was loaded. the
      existing code attempted to do this by comparing the actual address of
      the program headers (obtained via auxv) with the virtual address for
      the PT_PHDR record in the program headers. however, the linker seems
      to produce a PT_PHDR record only when a program interpreter (dynamic
      linker) is used. thus the computation failed and used the default base
      address of 0, leading to a crash when trying to access the TLS image
      at the wrong address.
      
      the dynamic linker entry point and static-PIE rcrt1.o startup code
      compute the base address instead by taking the difference between the
      run-time address of _DYNAMIC and the virtual address in the PT_DYNAMIC
      record. this patch copies the approach they use, but with a weak
      symbolic reference to _DYNAMIC instead of obtaining the address from
      the crt_arch.h asm. this works because relocations have already been
      performed at the time __init_tls is called.
      5bf7eba2
  10. 20 12月, 2016 2 次提交
    • R
      when building for arm as thumb2 code, also request assembly as thumb · 088c9674
      Rich Felker 提交于
      all assembly is now thumb2-compatible. on existing targets this is at
      best a size optimization, but it will also facilitate porting to
      thumb2-isa-only arm variants.
      088c9674
    • R
      rework arm atomic/tp backends to be thumb-compatible and fdpic-ready · 29237f7f
      Rich Felker 提交于
      three problems are addressed:
      
      - use of pc arithmetic, which was difficult if not impossible to make
        correct in thumb mode on all models, so that relative rather than
        absolute pointers to the backends could be used. this was designed
        back when there was no coherent model for the early stages of the
        dynamic linker before relocations, and is no longer necessary.
      
      - assumption that data (the relative pointers to the backends) can be
        accessed at a constant displacement from the code. this will not be
        possible on future fdpic subarchs (for cortex-m), so move
        responsibility for loading the backend code address to the caller.
      
      - hard-coded arm opcodes using the .word directive. instead, use the
        .arch directive to work around the assembler's refusal to assemble
        instructions not available (or in some cases, available but just
        considered deprecated) in the target isa level. the obscure v6t2
        arch is used for v6 code so as to (1) allow generation of thumb2
        output if -mthumb is active, and (2) avoid warnings/errors for mcr
        barriers that clang would produce if we just set arch to v7-a.
      
      in addition, the __aeabi_read_tp function is moved out of the inner
      workings and implemented as an asm wrapper around a C function, so
      that asm code does not need to read global data. the asm wrapper
      serves to satisfy the ABI calling convention requirements for this
      function.
      29237f7f
  11. 18 12月, 2016 3 次提交
  12. 17 12月, 2016 6 次提交
  13. 16 12月, 2016 1 次提交
    • R
      remove legacy i386 fallback stdarg implementation and framework · ffaaa6d2
      Rich Felker 提交于
      this has been slated for removal for a long time. there is
      fundamentally no way to implement stdarg without compiler assistance;
      any attempt to do so has serious undefined behavior; its working
      depends not just (as a common misconception goes) on ABI, but also on
      assumptions about compiler code generation internal to a translation
      unit, which is not subject to external ABI constraints.
      ffaaa6d2
  14. 07 12月, 2016 1 次提交
  15. 13 11月, 2016 1 次提交
    • R
      work around gdb issues recognizing sigreturn trampoline on x86_64 · 54991729
      Rich Felker 提交于
      gdb can only backtrace/unwind across signal handlers if it recognizes
      the sa_restorer trampoline. for x86_64, gdb first attempts to
      determine the symbol name for the function in which the program
      counter resides and match it against "__restore_rt". if no name can be
      found (e.g. in the case of a stripped binary), the exact instruction
      sequence is matched instead.
      
      when matching the function name, however, gdb's unwind code wrongly
      considers the interval [sym,sym+size] rather than [sym,sym+size).
      thus, if __restore_rt begins immediately after another function, gdb
      wrongly identifies pc as lying within the previous adjacent function.
      this patch adds a nop before __restore_rt to preclude that
      possibility. it also removes the symbol name __restore and replaces it
      with a macro since the stability of whether gdb identifies the
      function as __restore_rt or __restore is not clear.
      
      for the no-symbols case, the instruction sequence is changed to use
      %rax rather than %eax to match what gdb expects.
      
      based on patch by Szabolcs Nagy, with extended description and
      corresponding x32 changes added.
      54991729
  16. 12 11月, 2016 3 次提交
    • B
      add s390x port · 15094943
      Bobby Bingham 提交于
      15094943
    • B
      treat null vdso base same as missing · 54482898
      Bobby Bingham 提交于
      On s390x, the kernel provides AT_SYSINFO_EHDR, but sets it to zero, if the
      program being run does not have a program interpreter.  This causes
      problems when running the dynamic linker directly.
      54482898
    • R
      generalize ELF hash table types not to assume 32-bit entries · b418ea1b
      Rich Felker 提交于
      alpha and s390x gratuitously use 64-bit entries (wasting 2x space and
      cache utilization) despite the values always being 32-bit.
      
      based on patch by Bobby Bingham, with changes suggested by Alexander
      Monakov to use the public Elf_Symndx type from link.h (and make it
      properly variable by arch) rather than adding new internal
      infrastructure for handling the type.
      b418ea1b
  17. 09 11月, 2016 3 次提交
    • R
      fix build regression on archs with variable page size · 4078a5c3
      Rich Felker 提交于
      commit 31fb174d used
      DEFAULT_GUARD_SIZE from pthread_impl.h in a static initializer,
      breaking build on archs where its definition, PAGE_SIZE, is not a
      constant. instead, just define DEFAULT_GUARD_SIZE as 4096, the minimal
      page size on any arch we support. pthread_create rounds up to whole
      pages anyway, so defining it to 1 would also work, but a moderately
      meaningful value is nicer to programs that use
      pthread_attr_getguardsize on default-initialized attribute objects.
      4078a5c3
    • R
      add limited pthread_setattr_default_np API to set stack size defaults · 31fb174d
      Rich Felker 提交于
      based on patch by Timo Teräs:
      
      While generally this is a bad API, it is the only existing API to
      affect c++ (std::thread) and c11 (thrd_create) thread stack size.
      This patch allows applications only to increate stack and guard
      page sizes.
      31fb174d
    • R
      fix pthread_create regression from stack/guard size simplification · ea7891a6
      Rich Felker 提交于
      commit 33ce9208 broke pthread_create
      in the case where a null attribute pointer is passed; rather than
      using the default sizes, sizes of 0 (plus the remainder of one page
      after TLS/TCB use) were used.
      ea7891a6
  18. 08 11月, 2016 4 次提交
    • R
      make netinet/in.h suppress clashing definitions from kernel headers · 04983f22
      Rich Felker 提交于
      the linux kernel uapi headers provide their own definitions of the
      structures from netinet/in.h, resulting in errors when a program
      includes both the standard libc header and one or more of the
      networking-related kernel headers that pull in the kernel definitions.
      
      as before, we do not attempt to support the case where kernel headers
      are included before the libc ones, since the kernel definitions may
      have subtly incorrect types, namespace violations, etc. however, we
      can easily support the inclusion of the kernel headers after the libc
      ones, since the kernel headers provide a public interface for
      suppressing their definitions. this patch adds the necessary macro
      definitions for such suppression.
      04983f22
    • R
      simplify pthread_attr_t stack/guard size representation · 33ce9208
      Rich Felker 提交于
      previously, the pthread_attr_t object was always initialized all-zero,
      and stack/guard size were represented as differences versus their
      defaults. this required lots of confusing offset arithmetic everywhere
      they were used. instead, have pthread_attr_init fill in the default
      values, and work with absolute sizes everywhere.
      33ce9208
    • R
      fix swprintf internal buffer state and error handling · 7442442c
      Rich Felker 提交于
      the swprintf write callback never reset its buffer pointers, so after
      its 256-byte buffer filled up, it would keep repeating those bytes
      over and over in the output until the destination buffer filled up. it
      also failed to set the error indicator for the stream on EILSEQ,
      potentially allowing output to continue after the error.
      7442442c
    • D
      fix integer overflow of tm_year in __secs_to_tm · bc1e7731
      Daniel Sabogal 提交于
      the overflow check for years+100 did not account for the extra
      year computed from the remaining months. instead, perform this
      check after obtaining the final number of years.
      bc1e7731