diff --git a/src/temp/mkdtemp.c b/src/temp/mkdtemp.c index 162d98b0e38b1cfd760e80c7736f97fce1e0c03d..f2ecc5102ed996a92bf2da6bfdaf1bcf9899fc47 100644 --- a/src/temp/mkdtemp.c +++ b/src/temp/mkdtemp.c @@ -12,7 +12,8 @@ char *__mktemp(char *); char *mkdtemp(char *template) { - for (;;) { + int retries = 100; + while (retries--) { if (!__mktemp(template)) return 0; if (!mkdir(template, 0700)) return template; if (errno != EEXIST) return 0; @@ -20,4 +21,5 @@ char *mkdtemp(char *template) * that we have a valid template string */ strcpy(template+strlen(template)-6, "XXXXXX"); } + return 0; } diff --git a/src/temp/mkstemp.c b/src/temp/mkstemp.c index 3464256996a05a5b578ac055cf2fb77f3701d60b..2ab3020b3e3c2768a7c4abbd2f64415999e53807 100644 --- a/src/temp/mkstemp.c +++ b/src/temp/mkstemp.c @@ -11,8 +11,8 @@ char *__mktemp(char *); int mkstemp(char *template) { - int fd; - for (;;) { + int fd, retries = 100; + while (retries--) { if (!__mktemp(template)) return 0; if ((fd = open(template, O_RDWR | O_CREAT | O_EXCL, 0600))>=0) return fd; @@ -21,6 +21,7 @@ int mkstemp(char *template) * that we have a valid template string */ strcpy(template+strlen(template)-6, "XXXXXX"); } + return -1; } LFS64(mkstemp); diff --git a/src/temp/mktemp.c b/src/temp/mktemp.c index 1078b9df805e433ebd2d0f4fbe2ab87553e80df9..1462a16c6dd189ff8354656a924bfcc324ddc67b 100644 --- a/src/temp/mktemp.c +++ b/src/temp/mktemp.c @@ -4,28 +4,30 @@ #include #include #include +#include +#include #include "libc.h" char *__mktemp(char *template) { - static int lock; - static int index; - int l = strlen(template); + struct timespec ts; + size_t l = strlen(template); + int retries = 10000; + unsigned long r; if (l < 6 || strcmp(template+l-6, "XXXXXX")) { errno = EINVAL; - return NULL; + return 0; } - LOCK(&lock); - for (; index < 1000000; index++) { - snprintf(template+l-6, 6, "%06d", index); - if (access(template, F_OK) != 0) { - UNLOCK(&lock); - return template; - } + clock_gettime(CLOCK_REALTIME, &ts); + r = ts.tv_nsec + (uintptr_t)&ts / 16 + (uintptr_t)template; + while (retries--) { + snprintf(template+l-6, 7, "%06lX", r & 0xffffff); + if (access(template, F_OK) < 0) return template; + r = r * 1103515245 + 12345; } - UNLOCK(&lock); - return NULL; + errno = EEXIST; + return 0; } weak_alias(__mktemp, mktemp);