From e910a1aef4b2413c627240fc06d2a5696b24747a Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Sun, 30 Sep 2018 05:46:20 -0400 Subject: [PATCH] [util] Add empty virtual destructor to option_group_t From clang -Weverything bot: ./options.hh:57:8: warning: 'option_group_t' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor] struct option_group_t ^ --- util/options.hh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util/options.hh b/util/options.hh index 456e0a0f..0c929a22 100644 --- a/util/options.hh +++ b/util/options.hh @@ -56,6 +56,8 @@ void fail (hb_bool_t suggest_help, const char *format, ...) G_GNUC_NORETURN G_GN struct option_group_t { + virtual ~option_group_t () {} + virtual void add_options (struct option_parser_t *parser) = 0; virtual void pre_parse (GError **error G_GNUC_UNUSED) {}; -- GitLab