提交 d6aae5f5 编写于 作者: B Behdad Esfahbod

[HB] Cleanup TODOs

上级 122f21fb
...@@ -254,10 +254,10 @@ struct AlternateSubstFormat1 { ...@@ -254,10 +254,10 @@ struct AlternateSubstFormat1 {
unsigned int alt_index = 0; unsigned int alt_index = 0;
/* XXX callback to user to choose alternate /* XXX callback to user to choose alternate
if ( gsub->altfunc ) if (layout->altfunc)
alt_index = (gsub->altfunc)( buffer->out_pos, glyph_id, alt_index = (layout->altfunc)(layout, buffer,
aset.GlyphCount, aset.Alternate, buffer->out_pos, glyph_id,
gsub->data ); alt_set.len, alt_set.array);
*/ */
if (HB_UNLIKELY (alt_index >= alt_set.len)) if (HB_UNLIKELY (alt_index >= alt_set.len))
...@@ -370,7 +370,7 @@ struct Ligature { ...@@ -370,7 +370,7 @@ struct Ligature {
(buffer->in_pos)++; (buffer->in_pos)++;
} }
/* XXX We should possibly reassign lig_id and component for any /* TODO We should possibly reassign lig_id and component for any
* components of a previous ligature that s now being removed as part of * components of a previous ligature that s now being removed as part of
* this ligature. */ * this ligature. */
} }
...@@ -773,7 +773,7 @@ ASSERT_SIZE (GSUB, 10); ...@@ -773,7 +773,7 @@ ASSERT_SIZE (GSUB, 10);
inline bool ExtensionSubstFormat1::substitute (LOOKUP_ARGS_DEF) const { inline bool ExtensionSubstFormat1::substitute (LOOKUP_ARGS_DEF) const {
unsigned int lookup_type = get_type (); unsigned int lookup_type = get_type ();
/* TODO: belongs to sanitize() */ /* TODO belongs to sanitize() */
if (HB_UNLIKELY (lookup_type == GSUB_ReverseChainSingle)) if (HB_UNLIKELY (lookup_type == GSUB_ReverseChainSingle))
return false; return false;
......
...@@ -203,7 +203,7 @@ struct Null <Type> { \ ...@@ -203,7 +203,7 @@ struct Null <Type> { \
* Int types * Int types
*/ */
/* XXX define these as structs of chars on machines that do not allow /* TODO define these as structs of chars on machines that do not allow
* unaligned access (using templates?). */ * unaligned access (using templates?). */
#define DEFINE_INT_TYPE1(NAME, TYPE, BIG_ENDIAN) \ #define DEFINE_INT_TYPE1(NAME, TYPE, BIG_ENDIAN) \
inline NAME& operator = (TYPE i) { v = BIG_ENDIAN(i); return *this; } \ inline NAME& operator = (TYPE i) { v = BIG_ENDIAN(i); return *this; } \
......
...@@ -85,7 +85,7 @@ hb_ot_layout_destroy (hb_ot_layout_t *layout) ...@@ -85,7 +85,7 @@ hb_ot_layout_destroy (hb_ot_layout_t *layout)
* GDEF * GDEF
*/ */
/* XXX the public class_t is a mess */ /* TODO the public class_t is a mess */
hb_bool_t hb_bool_t
hb_ot_layout_has_font_glyph_classes (hb_ot_layout_t *layout) hb_ot_layout_has_font_glyph_classes (hb_ot_layout_t *layout)
...@@ -532,7 +532,7 @@ hb_ot_layout_substitute_lookup (hb_ot_layout_t *layout, ...@@ -532,7 +532,7 @@ hb_ot_layout_substitute_lookup (hb_ot_layout_t *layout,
/* XXX dupped, until he old code can be removed */ /* TODO dupped, until he old code can be removed */
static HB_Error static HB_Error
hb_buffer_duplicate_out_buffer( HB_Buffer buffer ) hb_buffer_duplicate_out_buffer( HB_Buffer buffer )
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册