diff --git a/src/hb-ot-layout-gsub-table.hh b/src/hb-ot-layout-gsub-table.hh index 255a2827e55616d14073248cde5a83598f3c0457..dfa50979a0c0e019d72abe517fabd1d9f1ee6520 100644 --- a/src/hb-ot-layout-gsub-table.hh +++ b/src/hb-ot-layout-gsub-table.hh @@ -541,18 +541,15 @@ struct AlternateSet unsigned int shift = hb_ctz (lookup_mask); unsigned int alt_index = ((lookup_mask & glyph_mask) >> shift); - if (unlikely (alt_index > count || alt_index == 0)) return_trace (false); - - /* This is ugly... If alt_index is 1, we take it as "on", and randomize - * feature if it is the rand feature. If it's > 1, it's a user-set value - * for sure, so respect it. So, user cannot set rand=1 and expect it to - * choose the first alternate... */ - if (alt_index == 1 && c->random) + /* If alt_index is MAX, randomize feature if it is the rand feature. */ + if (alt_index == HB_OT_MAP_MAX_VALUE && c->random) { c->random_state = (0x5DEECE66Dull * c->random_state + 11) & (((uint64_t) 1 << 48) - 1); alt_index = (c->random_state >> 32) % count + 1; } + if (unlikely (alt_index > count || alt_index == 0)) return_trace (false); + c->replace_glyph (alternates[alt_index - 1]); return_trace (true); diff --git a/src/hb-ot-layout-gsubgpos.hh b/src/hb-ot-layout-gsubgpos.hh index df03226465947451fde8cec974825f1ee137e869..be1b449c81ba3c7253053aac9fa459384c27ff01 100644 --- a/src/hb-ot-layout-gsubgpos.hh +++ b/src/hb-ot-layout-gsubgpos.hh @@ -33,6 +33,7 @@ #include "hb-buffer.hh" #include "hb-map.hh" #include "hb-set.hh" +#include "hb-ot-map.hh" #include "hb-ot-layout-common.hh" #include "hb-ot-layout-gdef-table.hh" diff --git a/src/hb-ot-map.cc b/src/hb-ot-map.cc index 8617f054bb06ddbd314c44afb6d8c085909b9e65..cb70583f44811e88c843140be9ed01fbdda96e59 100644 --- a/src/hb-ot-map.cc +++ b/src/hb-ot-map.cc @@ -210,8 +210,8 @@ hb_ot_map_builder_t::compile (hb_ot_map_t &m, /* Uses the global bit */ bits_needed = 0; else - /* Limit to 8 bits per feature. */ - bits_needed = MIN(8u, hb_bit_storage (info->max_value)); + /* Limit bits per feature. */ + bits_needed = MIN(HB_OT_MAP_MAX_BITS, hb_bit_storage (info->max_value)); if (!info->max_value || next_bit + bits_needed > 8 * sizeof (hb_mask_t)) continue; /* Feature disabled, or not enough bits. */ diff --git a/src/hb-ot-map.hh b/src/hb-ot-map.hh index 091cb3b661899077409f197b4e6b736f562c02d7..cc36fa2770169dd965881564a560c8e505a0e768 100644 --- a/src/hb-ot-map.hh +++ b/src/hb-ot-map.hh @@ -32,6 +32,9 @@ #include "hb-buffer.hh" +#define HB_OT_MAP_MAX_BITS 8u +#define HB_OT_MAP_MAX_VALUE ((1u << HB_OT_MAP_MAX_BITS) - 1u) + struct hb_ot_shape_plan_t; static const hb_tag_t table_tags[2] = {HB_OT_TAG_GSUB, HB_OT_TAG_GPOS}; diff --git a/src/hb-ot-shape.cc b/src/hb-ot-shape.cc index 00a8a6472332f11db421917881a779687e8b5502..437b0feb45cd9adaf39e1c66fc0cf5f2c45e6655 100644 --- a/src/hb-ot-shape.cc +++ b/src/hb-ot-shape.cc @@ -96,7 +96,7 @@ hb_ot_shape_collect_features (hb_ot_shape_planner_t *planner, map->add_feature (HB_TAG ('d','n','o','m'), 1, F_NONE); /* Random! */ - map->add_feature (HB_TAG ('r','a','n','d'), 1, F_GLOBAL | F_RANDOM); + map->add_feature (HB_TAG ('r','a','n','d'), HB_OT_MAP_MAX_VALUE, F_GLOBAL | F_RANDOM); if (planner->shaper->collect_features) planner->shaper->collect_features (planner);