diff --git a/interfaces/innerkits/fs_manager/libfs_hvb/fs_hvb.c b/interfaces/innerkits/fs_manager/libfs_hvb/fs_hvb.c index 186b7819a11382247f6a84e68db422df11f51a7c..2bcd1e8a319985205c7d21c83afd925f10204ff5 100755 --- a/interfaces/innerkits/fs_manager/libfs_hvb/fs_hvb.c +++ b/interfaces/innerkits/fs_manager/libfs_hvb/fs_hvb.c @@ -379,7 +379,7 @@ int FsHvbConstructVerityTarget(DmVerityTarget *target, const char *devName, stru } if (snprintf_s(&devPath[0], sizeof(devPath), sizeof(devPath) - 1, "%s%s", - ((strchr(devName "/") == NULL) ? FS_HVB_PARTITION_PREFIX : ""), devName) == -1) { + ((strchr(devName, '/') == NULL) ? FS_HVB_PARTITION_PREFIX : ""), devName) == -1) { BEGET_LOGE("error, snprintf_s devPath"); return -1; } diff --git a/interfaces/innerkits/syspara/param_comm.c b/interfaces/innerkits/syspara/param_comm.c index 12a8d86f5e27a65bda152dd7f1409a3fc4805e3b..acd55521f1b52b80cdd08caa7190ee7687491161 100644 --- a/interfaces/innerkits/syspara/param_comm.c +++ b/interfaces/innerkits/syspara/param_comm.c @@ -85,7 +85,7 @@ INIT_LOCAL_API int GetParameter_(const char *key, const char *def, char *value, return GetSystemError(ret); } -static PropertyValueProcessor propertyGetProcessor = NULL; +static PropertyValueProcessor g_propertyGetProcessor = NULL; INIT_LOCAL_API const char *GetProperty(const char *key, const char **paramHolder) { @@ -103,8 +103,8 @@ INIT_LOCAL_API const char *GetProperty(const char *key, const char **paramHolder free(res); return NULL; } - if (propertyGetProcessor != NULL) { - res = propertyGetProcessor(key, res); + if (g_propertyGetProcessor != NULL) { + res = g_propertyGetProcessor(key, res); } *paramHolder = res; } @@ -113,8 +113,8 @@ INIT_LOCAL_API const char *GetProperty(const char *key, const char **paramHolder INIT_LOCAL_API PropertyValueProcessor SetPropertyGetProcessor(PropertyValueProcessor processor) { - PropertyValueProcessor prev = propertyGetProcessor; - propertyGetProcessor = processor; + PropertyValueProcessor prev = g_propertyGetProcessor; + g_propertyGetProcessor = processor; return prev; } diff --git a/interfaces/innerkits/syspara/param_comm.h b/interfaces/innerkits/syspara/param_comm.h index d4025510ee7562354a4902f4fe4f656d316ffe5e..8d842014d155e9e78fcc622b6e45422139be17f6 100755 --- a/interfaces/innerkits/syspara/param_comm.h +++ b/interfaces/innerkits/syspara/param_comm.h @@ -30,7 +30,7 @@ extern "C" { #define DEV_BUF_LENGTH 3 #define DEV_BUF_MAX_LENGTH 1024 -typedef char * (*PropertyValueProcessor)(const char *key, char *value); +typedef char *(*PropertyValueProcessor)(const char *key, char *value); INIT_LOCAL_API const char *GetProperty(const char *key, const char **paramHolder); INIT_LOCAL_API PropertyValueProcessor SetPropertyGetProcessor(PropertyValueProcessor processor); diff --git a/services/begetctl/misc_daemon.cpp b/services/begetctl/misc_daemon.cpp index 77c7485c8b438c77b1e0ae2c5143e3c10d02e1a1..17d70e2299a1573de4e1114c67b0d21c2f343015 100755 --- a/services/begetctl/misc_daemon.cpp +++ b/services/begetctl/misc_daemon.cpp @@ -55,7 +55,7 @@ static void ClearLogo(int fd) } static void WriteLogoContent(int fd, const std::string &logoPath, uint32_t size) -{ +{ if (size == 0 || size > MAX_LOGO_SIZE) { BSH_LOGE("logo size is invalid!"); return; diff --git a/services/include/init_utils.h b/services/include/init_utils.h index 305d62cee09ee81dd96c950215e107f618235a5c..545b390c46afcf69a752e987891fbeb2fc01f0fe 100644 --- a/services/include/init_utils.h +++ b/services/include/init_utils.h @@ -61,11 +61,11 @@ char *ReadFileToBuf(const char *configFile); int GetProcCmdlineValue(const char *name, const char *buffer, char *value, int length); char *ReadFileData(const char *fileName); -typedef struct tagNAME_VALUE_PAIR{ +typedef struct NameValuePair { const char *name; - const char *name_end; + const char *nameEnd; const char *value; - const char *value_end; + const char *valueEnd; } NAME_VALUE_PAIR; int IterateNameValuePairs(const char *src, void (*iterator)(const NAME_VALUE_PAIR *nv, void *context), void *context); diff --git a/services/param/manager/param_server.c b/services/param/manager/param_server.c index f0bf40fd493f4b1733215f5d30a7b4f0727a774b..ce935d977d871f52dd00c1da30a6938d864b6858 100755 --- a/services/param/manager/param_server.c +++ b/services/param/manager/param_server.c @@ -36,15 +36,15 @@ #define OHOS_CMDLINE_PARA_PREFIX "ohos.boot." #define OHOS_CMDLINE_PARA_PREFIX_LEN 10 -typedef struct cmdLineInfo { +typedef struct CmdLineInfo { const char *name; int (*processor)(const char *name, const char *value); -} cmdLineInfo; +} CmdLineInfo; -typedef struct cmdLineIteratorCtx { +typedef struct CmdLineIteratorCtx { char *cmdline; bool gotSn; -} cmdLineIteratorCtx; +} CmdLineIteratorCtx; static int CommonDealFun(const char *name, const char *value) { @@ -109,9 +109,9 @@ static void CmdlineIterator(const NAME_VALUE_PAIR *nv, void *context) const char *name; const char *matched; char fullName[PARAM_NAME_LEN_MAX]; - cmdLineIteratorCtx *ctx = (cmdLineIteratorCtx *)context; + CmdLineIteratorCtx *ctx = (CmdLineIteratorCtx *)context; char *data = (char *)ctx->cmdline; - static const cmdLineInfo CMDLINES[] = { + static const CmdLineInfo CMDLINES[] = { { "hardware", CommonDealFun }, { "bootgroup", CommonDealFun }, { "reboot_reason", CommonDealFun }, @@ -121,8 +121,8 @@ static void CmdlineIterator(const NAME_VALUE_PAIR *nv, void *context) { "serialno", SnDealFun } }; - data[nv->name_end - data] = '\0'; - data[nv->value_end - data] = '\0'; + data[nv->nameEnd - data] = '\0'; + data[nv->valueEnd - data] = '\0'; PARAM_LOGV("proc cmdline: name [%s], value [%s]", nv->name, nv->value); // Get name without prefix @@ -185,7 +185,7 @@ static void GenerateSnByDefault(void) INIT_LOCAL_API int LoadParamFromCmdLine(void) { - cmdLineIteratorCtx ctx; + CmdLineIteratorCtx ctx; ctx.gotSn = false; ctx.cmdline = ReadFileData(BOOT_CMD_LINE); diff --git a/services/utils/init_utils.c b/services/utils/init_utils.c index 3a482dc5af689536bb8a9a3c1de4b20139c3ae86..d1e545915631fd7d75d67ad239d78d42892c024c 100644 --- a/services/utils/init_utils.c +++ b/services/utils/init_utils.c @@ -217,10 +217,10 @@ int IterateNameValuePairs(const char *src, void (*iterator)(const NAME_VALUE_PAI seperator = strchr(src, ' '); if (seperator == NULL) { // Last nv - nv.value_end = src + strlen(src); + nv.valueEnd = src + strlen(src); src = NULL; } else { - nv.value_end = seperator; + nv.valueEnd = seperator; src = seperator + 1; } @@ -230,11 +230,11 @@ int IterateNameValuePairs(const char *src, void (*iterator)(const NAME_VALUE_PAI // Invalid name value pair continue; } - if (seperator > nv.value_end) { + if (seperator > nv.valueEnd) { // name without value, just ignore continue; } - nv.name_end = seperator; + nv.nameEnd = seperator; nv.value = seperator + 1; iterator(&nv, context);