1. 26 1月, 2016 1 次提交
  2. 10 12月, 2015 1 次提交
    • I
      perf tui: Change default selection background color to yellow · 8d7d377c
      Ingo Molnar 提交于
      Boris reported that 'perf top' is unusable on his default 'black on
      white' terminal, which uses (eye friendly) light-grey as a background
      color.
      
      The reason is that the TUI cursor for the current selection line uses
      HE_COLORSET_SELECTED, and that has a default background color of
      'lightgrey' - which is a common terminal background choice and thus
      the colors conflict.
      
      Use yellow as the background color instead: that should be an uncommon
      terminal background, yet it's still ergonomic on both black and
      white/grey terminals.
      
      [ It would be a better solution to straight out detect color
        collisions and resolve them reasonably by converting them to RGB and
        calculating color space distances, but I was unable to find
        proper documentation for SLtt_get_color_object() to recover the
        current color scheme so I gave up ... Yellow works well enough. ]
      Reported-and-Tested-by: NBorislav Petkov <bp@alien8.de>
      Signed-off-by: NIngo Molnar <mingo@kernel.org>
      Tested-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      Cc: David Binderman <dcb314@hotmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Link: http://lkml.kernel.org/r/20150305103213.GA23046@gmail.comSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      8d7d377c
  3. 06 10月, 2015 1 次提交
    • A
      perf ui browser: Optional horizontal scrolling key binding · faae6f69
      Arnaldo Carvalho de Melo 提交于
      If the classes derived from ui_browser want to do some sort of
      horizontal scrolling, they have just to set ui_browser->columns to
      the number of columns available.
      
      Those columns can be the number of characters on the screen, if what is
      desired is to scroll character by character, or the number of columns in
      a spreadsheet like table.
      
      This is what the hist_browser will do, skipping ui_browser->horiz_scroll
      columns when rendering each of its lines.
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Borislav Petkov <bp@suse.de>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-q6a22bpmpgcr1awgzrmd4jrs@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      faae6f69
  4. 12 8月, 2015 2 次提交
  5. 07 7月, 2014 2 次提交
    • A
      perf ui browser: Allow overriding refresh_dimensions method · fa70b5d6
      Arnaldo Carvalho de Melo 提交于
      Some browsers, like the hist_browser, may want to be notified everytime
      a refresh_dimensions is needed, so that it can reset ui_browser->rows,
      for instance, or do some other related reaction to screen resizings.
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Don Zickus <dzickus@redhat.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-ielvluuemzn30bneh0zk3twi@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      fa70b5d6
    • A
      perf ui browser: Add ->rows to disambiguate from ->height · 62c95ae3
      Arnaldo Carvalho de Melo 提交于
      The ui_browser->height is about the whole browser "window", including
      any header, status lines or any other space needed for some "Yes", "No",
      etc buttons a descendent browser, like hist_browser, may have.
      
      Since the navigation is done mostly on the ui_browser methods, it needs
      to know how many rows are on the screen, while details about what other
      components are, say, if a header (that may be composed of multiple
      lines, etc) is present.
      
      Besides this we'll need to add a ui_browser->refresh_dimensions() hook
      so that browsers like hist_browser can update ->rows in response to
      screen resizes, this will come in a follow up patch.
      
      This patch just adds ->rows and updates it when updating ->height, keeps
      using ->height for the only other widget that can come with ui_browser,
      the scrollbar, that goes on using all the height on the rightmost column
      in the screen, using ->rows for the keyboard navigation needs.
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Don Zickus <dzickus@redhat.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-xexmwg1mv7u03j5imn66jdak@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      62c95ae3
  6. 20 6月, 2014 1 次提交
  7. 04 6月, 2014 1 次提交
  8. 28 12月, 2013 1 次提交
  9. 20 12月, 2013 1 次提交
  10. 15 11月, 2013 2 次提交
  11. 01 4月, 2013 1 次提交
  12. 25 1月, 2013 2 次提交
  13. 11 9月, 2012 1 次提交
    • I
      perf tools: Use __maybe_used for unused variables · 1d037ca1
      Irina Tirdea 提交于
      perf defines both __used and __unused variables to use for marking
      unused variables. The variable __used is defined to
      __attribute__((__unused__)), which contradicts the kernel definition to
      __attribute__((__used__)) for new gcc versions. On Android, __used is
      also defined in system headers and this leads to warnings like: warning:
      '__used__' attribute ignored
      
      __unused is not defined in the kernel and is not a standard definition.
      If __unused is included everywhere instead of __used, this leads to
      conflicts with glibc headers, since glibc has a variables with this name
      in its headers.
      
      The best approach is to use __maybe_unused, the definition used in the
      kernel for __attribute__((unused)). In this way there is only one
      definition in perf sources (instead of 2 definitions that point to the
      same thing: __used and __unused) and it works on both Linux and Android.
      This patch simply replaces all instances of __used and __unused with
      __maybe_unused.
      Signed-off-by: NIrina Tirdea <irina.tirdea@intel.com>
      Acked-by: NPekka Enberg <penberg@kernel.org>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Namhyung Kim <namhyung.kim@lge.com>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Steven Rostedt <rostedt@goodmis.org>
      Link: http://lkml.kernel.org/r/1347315303-29906-7-git-send-email-irina.tirdea@intel.com
      [ committer note: fixed up conflict with a116e05d in builtin-sched.c ]
      Signed-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      1d037ca1
  14. 30 5月, 2012 2 次提交
  15. 04 5月, 2012 2 次提交
  16. 28 4月, 2012 1 次提交
  17. 25 4月, 2012 1 次提交
    • A
      perf annotate browser: Initial loop detection · a3f895be
      Arnaldo Carvalho de Melo 提交于
      Simple algorithm, just look for the next backward jump that points to
      before the cursor.
      
      Then draw an arrow connecting the jump to its target.
      
      Do this as you move the cursor, entering/exiting possible loops.
      
      Ex (graph chars replaced to avoid mail encoding woes):
      
      avc_has_perm_flags
          0.00 |         nopl   0x0(%rax)
          5.36 |+-> 68:  mov    (%rax),%rax
          5.15 ||        test   %rax,%rax
          0.00 ||      v je     130
          2.96 ||   74:  cmp    -0x20(%rax),%ebx
         47.38 ||        lea    -0x20(%rax),%rcx
          0.28 ||      ^ jne    68
          3.16 ||        cmp    -0x18(%rax),%dx
          0.00 |+------^ jne    68
          4.92 |         cmp    0x4(%rcx),%r13d
          0.00 |       v jne    68
          1.15 |         test   %rcx,%rcx
          0.00 |       v je     130
      Suggested-by: NLinus Torvalds <torvalds@linux-foundation.org>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Linus Torvalds <torvalds@linux-foundation.org>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: Namhyung Kim <namhyung@gmail.com>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-5gairf6or7dazlx3ocxwvftm@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      a3f895be
  18. 21 4月, 2012 1 次提交
  19. 12 4月, 2012 1 次提交
  20. 08 4月, 2012 2 次提交
  21. 02 11月, 2011 1 次提交
  22. 26 10月, 2011 4 次提交
  23. 21 10月, 2011 1 次提交
  24. 19 10月, 2011 3 次提交
  25. 14 10月, 2011 2 次提交
  26. 13 10月, 2011 2 次提交