提交 fc16c25f 编写于 作者: J Jeff Garzik

[libata] ACPI: remove needless ->qc_issue hook existence test

All drivers must implement this hook, otherwise ATA commands would go
nowhere (and a lot of other oopsen would appear as well).
Signed-off-by: NJeff Garzik <jeff@garzik.org>
上级 ea34e45a
...@@ -455,6 +455,9 @@ static void taskfile_load_raw(struct ata_port *ap, ...@@ -455,6 +455,9 @@ static void taskfile_load_raw(struct ata_port *ap,
struct ata_device *atadev, struct ata_device *atadev,
const struct taskfile_array *gtf) const struct taskfile_array *gtf)
{ {
struct ata_taskfile tf;
unsigned int err;
if (ata_msg_probe(ap)) if (ata_msg_probe(ap))
ata_dev_printk(atadev, KERN_DEBUG, "%s: (0x1f1-1f7): hex: " ata_dev_printk(atadev, KERN_DEBUG, "%s: (0x1f1-1f7): hex: "
"%02x %02x %02x %02x %02x %02x %02x\n", "%02x %02x %02x %02x %02x %02x %02x\n",
...@@ -467,10 +470,6 @@ static void taskfile_load_raw(struct ata_port *ap, ...@@ -467,10 +470,6 @@ static void taskfile_load_raw(struct ata_port *ap,
&& (gtf->tfa[6] == 0)) && (gtf->tfa[6] == 0))
return; return;
if (ap->ops->qc_issue) {
struct ata_taskfile tf;
unsigned int err;
ata_tf_init(atadev, &tf); ata_tf_init(atadev, &tf);
/* convert gtf to tf */ /* convert gtf to tf */
...@@ -490,12 +489,6 @@ static void taskfile_load_raw(struct ata_port *ap, ...@@ -490,12 +489,6 @@ static void taskfile_load_raw(struct ata_port *ap,
ata_dev_printk(atadev, KERN_ERR, ata_dev_printk(atadev, KERN_ERR,
"%s: ata_exec_internal failed: %u\n", "%s: ata_exec_internal failed: %u\n",
__FUNCTION__, err); __FUNCTION__, err);
} else
if (ata_msg_warn(ap))
ata_dev_printk(atadev, KERN_WARNING,
"%s: SATA driver is missing qc_issue function"
" entry points\n",
__FUNCTION__);
} }
/** /**
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册