提交 f83be4c3 编写于 作者: A Axel Lin 提交者: Kishon Vijay Abraham I

phy: core: Fix error checking in (devm_)phy_optional_get

Don't pass valid pointer to PTR_ERR, use PTR_ERR(phy) only when
IS_ERR(phy) is true.
Signed-off-by: NAxel Lin <axel.lin@ingics.com>
Signed-off-by: NKishon Vijay Abraham I <kishon@ti.com>
上级 2decb268
...@@ -530,7 +530,7 @@ struct phy *phy_optional_get(struct device *dev, const char *string) ...@@ -530,7 +530,7 @@ struct phy *phy_optional_get(struct device *dev, const char *string)
{ {
struct phy *phy = phy_get(dev, string); struct phy *phy = phy_get(dev, string);
if (PTR_ERR(phy) == -ENODEV) if (IS_ERR(phy) && (PTR_ERR(phy) == -ENODEV))
phy = NULL; phy = NULL;
return phy; return phy;
...@@ -584,7 +584,7 @@ struct phy *devm_phy_optional_get(struct device *dev, const char *string) ...@@ -584,7 +584,7 @@ struct phy *devm_phy_optional_get(struct device *dev, const char *string)
{ {
struct phy *phy = devm_phy_get(dev, string); struct phy *phy = devm_phy_get(dev, string);
if (PTR_ERR(phy) == -ENODEV) if (IS_ERR(phy) && (PTR_ERR(phy) == -ENODEV))
phy = NULL; phy = NULL;
return phy; return phy;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册