提交 cd1420d3 编写于 作者: A Arnd Bergmann 提交者: Alexandre Belloni

rtc: pfc8563: fix uninitialized variable warning

Gcc is unable to prove that alm_pending is always initialized
when it is used, so it prints a harmless warning:

drivers/rtc/rtc-pcf8563.c: In function 'pcf8563_probe':
drivers/rtc/rtc-pcf8563.c:449:5: warning: 'alm_pending' may be used uninitialized in this function [-Wmaybe-uninitialized]

This uses the same conditional expression that is used inside of
the pcf8563_get_alarm_mode() function, to help gcc figure it out
and shut up that warning, and make the ARM defconfigs build again
with no warnings.
Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Fixes: a45d528a ("rtc: pcf8563: clear expired alarm at boot time")
Signed-off-by: NAlexandre Belloni <alexandre.belloni@free-electrons.com>
上级 e3edd671
......@@ -432,7 +432,7 @@ static int pcf8563_probe(struct i2c_client *client,
}
err = pcf8563_get_alarm_mode(client, NULL, &alm_pending);
if (err < 0) {
if (err) {
dev_err(&client->dev, "%s: read error\n", __func__);
return err;
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册