提交 cbcc607e 编写于 作者: A Arkadi Sharshevsky 提交者: David S. Miller

team: Fix double free in error path

The __send_and_alloc_skb() receives a skb ptr as a parameter but in
case it fails the skb is not valid:
- Send failed and released the skb internally.
- Allocation failed.

The current code tries to release the skb in case of failure which
causes redundant freeing.

Fixes: 9b00cf2d ("team: implement multipart netlink messages for options transfers")
Signed-off-by: NArkadi Sharshevsky <arkadis@mellanox.com>
Acked-by: NJiri Pirko <jiri@mellanox.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 cfda06d7
...@@ -2395,7 +2395,7 @@ static int team_nl_send_options_get(struct team *team, u32 portid, u32 seq, ...@@ -2395,7 +2395,7 @@ static int team_nl_send_options_get(struct team *team, u32 portid, u32 seq,
if (!nlh) { if (!nlh) {
err = __send_and_alloc_skb(&skb, team, portid, send_func); err = __send_and_alloc_skb(&skb, team, portid, send_func);
if (err) if (err)
goto errout; return err;
goto send_done; goto send_done;
} }
...@@ -2681,7 +2681,7 @@ static int team_nl_send_port_list_get(struct team *team, u32 portid, u32 seq, ...@@ -2681,7 +2681,7 @@ static int team_nl_send_port_list_get(struct team *team, u32 portid, u32 seq,
if (!nlh) { if (!nlh) {
err = __send_and_alloc_skb(&skb, team, portid, send_func); err = __send_and_alloc_skb(&skb, team, portid, send_func);
if (err) if (err)
goto errout; return err;
goto send_done; goto send_done;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册