提交 abf04402 编写于 作者: J Julia Lawall 提交者: Guenter Roeck

hwmon: (jz4740) use permission-specific DEVICE_ATTR variants

Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source
code, improves readbility, and reduces the chance of inconsistencies.

The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.
Signed-off-by: NJulia Lawall <Julia.Lawall@lip6.fr>
[groeck: Updated description]
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>
上级 3edf03b3
...@@ -44,7 +44,7 @@ static irqreturn_t jz4740_hwmon_irq(int irq, void *data) ...@@ -44,7 +44,7 @@ static irqreturn_t jz4740_hwmon_irq(int irq, void *data)
return IRQ_HANDLED; return IRQ_HANDLED;
} }
static ssize_t jz4740_hwmon_read_adcin(struct device *dev, static ssize_t in0_input_show(struct device *dev,
struct device_attribute *dev_attr, char *buf) struct device_attribute *dev_attr, char *buf)
{ {
struct jz4740_hwmon *hwmon = dev_get_drvdata(dev); struct jz4740_hwmon *hwmon = dev_get_drvdata(dev);
...@@ -79,7 +79,7 @@ static ssize_t jz4740_hwmon_read_adcin(struct device *dev, ...@@ -79,7 +79,7 @@ static ssize_t jz4740_hwmon_read_adcin(struct device *dev,
return ret; return ret;
} }
static DEVICE_ATTR(in0_input, S_IRUGO, jz4740_hwmon_read_adcin, NULL); static DEVICE_ATTR_RO(in0_input);
static struct attribute *jz4740_attrs[] = { static struct attribute *jz4740_attrs[] = {
&dev_attr_in0_input.attr, &dev_attr_in0_input.attr,
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册