• M
    sched/sysctl: Fix attributes of some extern declarations · a9903f04
    Matthias Kaehlcke 提交于
    The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate
    and sysctl_sched_time_avg includes the attribute const_debug. This
    attribute is not part of the extern declaration of these variables in
    include/linux/sched/sysctl.h, while it is in kernel/sched/sched.h,
    and as a result Clang generates warnings like this:
    
      kernel/sched/sched.h:1618:33: warning: section attribute is specified on redeclared variable [-Wsection]
      extern const_debug unsigned int sysctl_sched_time_avg;
                                    ^
      ./include/linux/sched/sysctl.h:42:21: note: previous declaration is here
      extern unsigned int sysctl_sched_time_avg;
    
    The header only declares the variables when CONFIG_SCHED_DEBUG is defined,
    therefore it is not necessary to duplicate the definition of const_debug.
    Instead we can use the attribute __read_mostly, which is the expansion of
    const_debug when CONFIG_SCHED_DEBUG=y is set.
    Signed-off-by: NMatthias Kaehlcke <mka@chromium.org>
    Reviewed-by: NNick Desaulniers <nick.desaulniers@gmail.com>
    Cc: Douglas Anderson <dianders@chromium.org>
    Cc: Guenter Roeck <groeck@chromium.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Shile Zhang <shile.zhang@nokia.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Link: http://lkml.kernel.org/r/20171030180816.170850-1-mka@chromium.orgSigned-off-by: NIngo Molnar <mingo@kernel.org>
    a9903f04
sysctl.h 2.5 KB