Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

There's no need to have the name of the "run_<name>" method (main
test entry point) depend on the test name. So, for simplicity sake,
let's just name the test entry point "run".

I have decided to not fallback gracefully to the previous naming
convention as I believe this can lead to confusion in the future.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

As already have the command for Window guests in guest-os cfg files,
remove the only Linux in floppy_test.cfg. And the mount_dir is
a parameter only for Linux guest. So remove the force requirement
for the parameter.
Signed-off-by: NYiqiao Pu <ypu@redhat.com>

In order to make the utils_test module more maintainable,
split the qemu tests specific functions to the module
utils_test.qemu. Of course, eventually modules specific
to other test types, such as libvirt, v2v and the such
can be also carried.

All the API references were fixed, and functions that
were mentioned in a single test module were moved to
said test module.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Make virt-test to have a docstring style mostly compliant with
the sphinx's [1] format, reStructured text. This means that
we have to trade all '@' tags to be ':', mostly.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

With the help of the PEP8 script, a semi-automated clean
of the code base was made, and effectively changing some
of the coding style rules of our code base:

 * No more 2 lines spacing among functions
 * No more combined module imports

In the end, it was going to be too difficult to take
into consideration E501 (line length > 80) errors and
W601 (.has_key() is deprecated), so these were ignored,
at least for now.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Using the program codespell

https://github.com/lucasdemarchi/codespell

We found a number of spelling mistakes, that could be
found and fixed. The result of the automated script
was double checked, of course.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

When fail to get vm from env file, we will meet following issue:
Traceback (most recent call last):
  File "/root/ypu/autotest_upstream_master/client/shared/test.py", line 426, in _exec
    _call_test_function(self.execute, *p_args, **p_dargs)
  File "/root/ypu/autotest_upstream_master/client/shared/test.py", line 853, in _call_test_function
    raise error.UnhandledTestFail(e)
UnhandledTestFail: Unhandled AttributeError: 'NoneType' object has no attribute 'create'    [context: Boot up guest with a floppy]
Traceback (most recent call last):
  File "/root/ypu/autotest_upstream_master/client/shared/test.py", line 846, in _call_test_function
    return func(*args, **dargs)
  File "/root/ypu/autotest_upstream_master/client/shared/test.py", line 299, in execute
    postprocess_profiled_run, args, dargs)
  File "/root/ypu/autotest_upstream_master/client/shared/test.py", line 216, in _call_run_once
    *args, **dargs)
  File "/root/ypu/autotest_upstream_master/client/shared/test.py", line 322, in run_once_profiling
    self.run_once(*args, **dargs)
  File "/root/ypu/autotest_upstream_master/client/tests/virt/virt.py", line 133, in run_once
    run_func(self, params, env)
  File "/root/ypu/autotest_upstream_master/client/shared/error.py", line 138, in new_fn
    return fn(*args, **kwargs)
  File "/root/ypu/autotest_upstream_master/client/tests/virt/qemu/tests/floppy.py", line 33, in run_floppy
    vm.create()
AttributeError: 'NoneType' object has no attribute 'create'

Call env_process.preprocess_vm(test, params, env, vm_name) to create vm could skip this issue.
Signed-off-by: NFeng Yang <fyang@redhat.com>

Signed-off-by: NJiří Župka <jzupka@redhat.com>

Signed-off-by: NJiří Župka <jzupka@redhat.com>

This patch benefits from the better error message when key is missing
in config params. Instead of custom handling of missing param it
uses params[] directly.

I modified those params, where I was 100% certain that they are
required and doesn't have default value:
 * val = params.get(..) followed by if not val: raise...
 * int(params.get(...))
 * params.get(...).split()
 * commands which require string (eg. session.cmd(params.get(...)))

I didn't test all the tests before and after in order to verify
possible typos but I used pylint before and after, watching for
new errors (code rate before and after).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

In order to be consistent with previous changes.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

A frequent request we've got from users is that the name
'kvm' makes assumptions that are not true for a lot of
the use cases of the test suite. Then let's rename
the subtest 'kvm' to 'qemu', making it more accurate.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

The floppy test, in order to work among Windows and Linux,
was using a diff command to determine whether a file copied
to the floppy had its integrity preserved. The diff command
was not present on JeOS, but fortunately it is not necessary,
since we can simply evaluate the md5sum of the files.

Also, fix the relative positioning of the floppy files, using
the data_dir API.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>