From 40b54698127661b227255d4a0e3a314325fd9bdc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luk=C3=A1=C5=A1=20Doktor?= Date: Tue, 9 Aug 2016 12:21:50 +0200 Subject: [PATCH] qemu: Remove unnecessary cleanup in virtio_console test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The removed functions are suppose to clean previously set signals, which is not really needed as the `set_poll_want_return` itself cleans the signals. The only exception is when we close the port so let's add a 0.5s delay in order to make sure the signal was already emitted and wont corrupt the testing. Signed-off-by: Lukáš Doktor --- qemu/tests/virtio_console.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/qemu/tests/virtio_console.py b/qemu/tests/virtio_console.py index d363e5b2..eeee7e2e 100644 --- a/qemu/tests/virtio_console.py +++ b/qemu/tests/virtio_console.py @@ -320,12 +320,10 @@ def run(test, params, env): params.get('virtio_console_params')) if port.is_open(): port.close() + time.sleep(0.5) # wait for SIGHUP to be emitted - # Read out the previous signals - guest_worker._cmd("virt.get_sigio_poll_return('%s')" % (port.name), 1) # Enable sigio on specific port guest_worker.cmd("virt.async('%s', True, 0)" % (port.name), 10) - guest_worker.cmd("virt.get_sigio_poll_return('%s')" % (port.name), 10) # Test sigio when port open guest_worker.cmd("virt.set_pool_want_return('%s', select.POLLOUT)" % -- GitLab