1. 03 8月, 2010 1 次提交
  2. 19 5月, 2010 2 次提交
  3. 18 5月, 2010 2 次提交
  4. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  5. 27 2月, 2010 5 次提交
  6. 16 12月, 2009 3 次提交
  7. 06 12月, 2009 8 次提交
  8. 27 11月, 2009 1 次提交
  9. 19 9月, 2009 4 次提交
  10. 15 9月, 2009 1 次提交
  11. 13 9月, 2009 2 次提交
  12. 12 9月, 2009 6 次提交
  13. 31 8月, 2009 2 次提交
  14. 14 8月, 2009 2 次提交
    • M
      V4L/DVB (12405): em28xx-cards: move register 0x13 setting to the proper place · d7612c86
      Mauro Carvalho Chehab 提交于
      Register 0x13 seems to be a sort of image control, maybe gamma, white
      level or black level. Lower values produce better images, while higher
      values increases the contrast and shifts colors to green. 0xff produces
      a black image. This register is not Silvercrest-specific, so its code
      should be moved to a better place.
      
      If this register is left alone, a random value can be found at the
      register, producing weird results.
      
      While here, let's remove register 0x0d, as it had no noticed effect at
      the image.
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      d7612c86
    • M
      V4L/DVB (12411): em28xx: Fix artifacts with Silvercrest webcam · 3d3215c4
      Mauro Carvalho Chehab 提交于
      Silvercrest mt9v011 sensor produces a 640x480 image. However,
      previously, the code were getting only half of the lines and merging two
      consecutive frames to "produce" a 640x480 image.
      
      With the addition of progressive mode, now em28xx is working with a full
      image. However, when the number of lines is bigger than 240, the
      beginning of some odd lines are filled with blank.
      
      After lots of testing, and physically checking the device for a Xtal, it
      was noticed experimentally that mt9v011 is using em28xx XCLK as its
      clock. Due to that, changing XCLK value changes the maximum speed of the
      stream.
      
      At the tests, it were possible to produce up to 32 fps, using a 30 MHz
      XCLK. However, at that rate, the artifacts happen even at 320x240. Lower
      values of XCLK produces artifacts only at 640x480.
      
      At some values of xclk (for example XCLKK = 6 MHz, 640x480), it is
      possible to see an invalid sucession of artifacts with this pattern:
      
      .xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      ..xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      ...xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      ....xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      .xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      ..xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      ...xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      ....xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      
      (where the dots represent the blanked pixels)
      
      So, it seems that a waveform in the format of a ramp is interferring at
      the image.
      
      The cause of this interference is currently unknown. Some possibilities
      are:
      	- electrical interference (maybe this device is broken?);
      	- some issue at mt9v011 programming;
      	- some bug at em28xx chip.
      
      So, for now, let's be conservative and use a value of XCLK that we know
      for sure that it won't cause artifacts.
      
      As I'm waiting for more of such devices with different em28xx chipset
      revisions, I'll have the opportunity to double check the issue with
      other pieces of hardware.
      
      Later patches can vary XCLK depending on the vertical resolutions, if a
      proper fix is not discovered.
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      3d3215c4