提交 fe5c671f 编写于 作者: K Kangjie Lu 提交者: Xie XiuQi

thunderbolt: property: Fix a NULL pointer dereference

[ Upstream commit 106204b56f60abf1bead7dceb88f2be3e34433da ]

In case kzalloc fails, the fix releases resources and returns
-ENOMEM to avoid the NULL pointer dereference.
Signed-off-by: NKangjie Lu <kjlu@umn.edu>
Signed-off-by: NMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: NSasha Levin <sashal@kernel.org>
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
上级 c2978c6e
...@@ -551,6 +551,11 @@ int tb_property_add_data(struct tb_property_dir *parent, const char *key, ...@@ -551,6 +551,11 @@ int tb_property_add_data(struct tb_property_dir *parent, const char *key,
property->length = size / 4; property->length = size / 4;
property->value.data = kzalloc(size, GFP_KERNEL); property->value.data = kzalloc(size, GFP_KERNEL);
if (!property->value.data) {
kfree(property);
return -ENOMEM;
}
memcpy(property->value.data, buf, buflen); memcpy(property->value.data, buf, buflen);
list_add_tail(&property->list, &parent->properties); list_add_tail(&property->list, &parent->properties);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册