cifs: allow calling SMB2_xxx_free(NULL)

mainline inclusion
from mainline-4.20
commit 32a1fb36f6e5
category: bugfix
bugzilla: 5875
CVE: NA

-------------------------------------------------

Change these free functions to allow passing NULL as the argument and
treat it as a no-op just like free(NULL) would.
Or, if rqst->rq_iov is NULL.

The second scenario could happen for smb2_queryfs() if the call
to SMB2_query_info_init() fails and we go to qfs_exit to clean up
and free all resources.
In that case we have not yet assigned rqst[2].rq_iov and thus
the rq_iov dereference in SMB2_close_free() will cause a NULL pointer
dereference.

Fixes:  1eb9fb52 ("cifs: create SMB2_open_init()/SMB2_open_free() helpers")

conflict:
	fs/cifs/smb2pdu.c
 ba8ca1168 cifs: create helpers for SMB2_set_info_init/free()
Signed-off-by: NRonnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: NSteve French <stfrench@microsoft.com>
Reviewed-by: NAurelien Aptel <aaptel@suse.com>
CC: Stable <stable@vger.kernel.org>
Signed-off-by: NZhangXiaoxu <zhangxiaoxu5@huawei.com>
Reviewed-by: NMiao Xie <miaoxie@huawei.com>
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>

fs/cifs/smb2pdu.c

@@ -2243,10 +2243,12 @@ SMB2_open_free(struct smb_rqst *rqst)
 {
 	int i;
 
+	if (rqst && rqst->rq_iov) {
 		cifs_small_buf_release(rqst->rq_iov[0].iov_base);
 		for (i = 1; i < rqst->rq_nvec; i++)
 			if (rqst->rq_iov[i].iov_base != smb2_padding)
 				kfree(rqst->rq_iov[i].iov_base);
+	}
 }
 
 int
@@ -2535,6 +2537,7 @@ SMB2_close_init(struct cifs_tcon *tcon, struct smb_rqst *rqst,
 void
 SMB2_close_free(struct smb_rqst *rqst)
 {
+	if (rqst && rqst->rq_iov)
 		cifs_small_buf_release(rqst->rq_iov[0].iov_base); /* request */
 }
 
@@ -2685,6 +2688,7 @@ SMB2_query_info_init(struct cifs_tcon *tcon, struct smb_rqst *rqst,
 void
 SMB2_query_info_free(struct smb_rqst *rqst)
 {
+	if (rqst && rqst->rq_iov)
 		cifs_small_buf_release(rqst->rq_iov[0].iov_base); /* request */
 }