From d0178c4f345d6cee17718be0b1b33ee09a6a36f9 Mon Sep 17 00:00:00 2001 From: Nicolas Saenz Julienne Date: Wed, 6 Nov 2019 15:48:38 +0800 Subject: [PATCH] firmware: arm_sdei: fix wrong of_node_put() in init function mainline inclusion from mainline-4.20 commit c3790b3799f8 category: bugfix bugzilla: 24618 CVE: NA ------------ After finding a "firmware" dt node arm_sdei tries to match it's compatible string with it. To do so it's calling of_find_matching_node() which already takes care of decreasing the refcount on the "firmware" node. We are then incorrectly decreasing the refcount on that node again. This patch removes the unwarranted call to of_node_put(). Signed-off-by: Nicolas Saenz Julienne Signed-off-by: James Morse Signed-off-by: Will Deacon Signed-off-by: Lijun Fang Reviewed-by: Hanjun Guo Signed-off-by: Yang Yingliang --- drivers/firmware/arm_sdei.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c index 502e3dd84f7e..ac76fd1b8c2d 100644 --- a/drivers/firmware/arm_sdei.c +++ b/drivers/firmware/arm_sdei.c @@ -1042,7 +1042,6 @@ static bool __init sdei_present_dt(void) return false; np = of_find_matching_node(fw_np, sdei_of_match); - of_node_put(fw_np); if (!np) return false; -- GitLab