From cd0fb3bcd64c7fef196d0997710fee2dbdadca10 Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Wed, 13 Feb 2019 15:00:20 +0800 Subject: [PATCH] pcrypt: use format specifier in kobject_add mainline inclusion from mainline-5.0-rc1 commit b1e3874c75ab15288f573b3532e507c37e8e7656 category: bugfix bugzilla: 6251 CVE: nA --------------------------- Passing string 'name' as the format specifier is potentially hazardous because name could (although very unlikely to) have a format specifier embedded in it causing issues when parsing the non-existent arguments to these. Follow best practice by using the "%s" format string for the string 'name'. Cleans up clang warning: crypto/pcrypt.c:397:40: warning: format string is not a string literal (potentially insecure) [-Wformat-security] Fixes: a3fb1e330dd2 ("pcrypt: Added sysfs interface to pcrypt") Signed-off-by: Colin Ian King Signed-off-by: Herbert Xu Signed-off-by: Jason Yan Reviewed-by: Zhang xiaoxu Signed-off-by: Yang Yingliang --- crypto/pcrypt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/pcrypt.c b/crypto/pcrypt.c index f8ec3d4ba4a8..a5718c0a3dc4 100644 --- a/crypto/pcrypt.c +++ b/crypto/pcrypt.c @@ -394,7 +394,7 @@ static int pcrypt_sysfs_add(struct padata_instance *pinst, const char *name) int ret; pinst->kobj.kset = pcrypt_kset; - ret = kobject_add(&pinst->kobj, NULL, name); + ret = kobject_add(&pinst->kobj, NULL, "%s", name); if (!ret) kobject_uevent(&pinst->kobj, KOBJ_ADD); -- GitLab