From c70a19f725f71b1f87de179b4273b71b7da376dc Mon Sep 17 00:00:00 2001 From: Shaozhengchao Date: Wed, 18 Mar 2020 14:44:08 +0800 Subject: [PATCH] net/hinic: Magic number rectification driver inclusion category:bugfix bugzilla:4472 CVE:NA ----------------------------------------------------------------------- Magic number rectification Signed-off-by: Shaozhengchao Reviewed-by: Luoshaokai Signed-off-by: Yang Yingliang --- drivers/net/ethernet/huawei/hinic/hinic_ethtool.c | 2 +- drivers/net/ethernet/huawei/hinic/hinic_hwdev.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c b/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c index ac711daad06f..92bad0e159ae 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_ethtool.c @@ -1429,7 +1429,7 @@ static int __hinic_set_coalesce(struct net_device *netdev, struct hinic_nic_dev *nic_dev = netdev_priv(netdev); struct hinic_intr_coal_info intr_coal = {0}; struct hinic_intr_coal_info *ori_intr_coal; - char obj_str[32] = {0}; + char obj_str[OBJ_STR_MAX_LEN] = {0}; u16 i; int err = 0; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c b/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c index c2454f6d56bb..8d6675c5039a 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hwdev.c @@ -3890,8 +3890,8 @@ char *__hw_to_char_port_type[LINK_PORT_MAX_TYPE] = { static void __print_cable_info(struct hinic_hwdev *hwdev, struct hinic_link_info *info) { - char tmp_str[512] = {0}; - char tmp_vendor[17] = {0}; + char tmp_str[CAP_INFO_MAC_LEN] = {0}; + char tmp_vendor[VENDOR_MAX_LEN] = {0}; char *port_type = "Unknown port type"; int i; int err = 0; -- GitLab