Revert "iommu/arm-smmu-v3: workaround for STE abort in kdump kernel"

euler inclusion
category: bugfix
bugzilla: 5452
CVE: NA

-------------------------------------------------------------------------

This reverts commit 021e3b3952904d784d6c64d76c08ea9fea835286.
Signed-off-by: NZhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: NHanjun Guo <guohanjun@huawei.com>
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>

drivers/iommu/arm-smmu-v3.c

@@ -221,12 +221,10 @@
 #define STRTAB_SPLIT			8
 
 #define STRTAB_L1_DESC_DWORDS		1
-#define STRTAB_L1_DESC_SIZE		(STRTAB_L1_DESC_DWORDS << 3)
 #define STRTAB_L1_DESC_SPAN		GENMASK_ULL(4, 0)
 #define STRTAB_L1_DESC_L2PTR_MASK	GENMASK_ULL(51, 6)
 
 #define STRTAB_STE_DWORDS		8
-#define STRTAB_STE_SIZE			(STRTAB_STE_DWORDS << 3)
 #define STRTAB_STE_0_V			(1UL << 0)
 #define STRTAB_STE_0_CFG		GENMASK_ULL(3, 1)
 #define STRTAB_STE_0_CFG_ABORT		0
@@ -336,8 +334,6 @@
 #define EVTQ_MAX_SZ_SHIFT		7
 
 #define EVTQ_0_ID			GENMASK_ULL(7, 0)
-#define EVTQ_0_ID_C_BAD_STE		0x4
-
 #define EVT_ID_TRANSLATION_FAULT	0x10
 #define EVT_ID_ADDR_SIZE_FAULT		0x11
 #define EVT_ID_ACCESS_FAULT		0x12
@@ -564,7 +560,6 @@ struct arm_smmu_strtab_ent {
 struct arm_smmu_strtab_cfg {
 	__le64				*strtab;
 	dma_addr_t			strtab_dma;
-	dma_addr_t			former_strtab_dma;
 	struct arm_smmu_strtab_l1_desc	*l1_desc;
 	unsigned int			num_l1_ents;
 
@@ -1405,62 +1400,6 @@ static int arm_smmu_init_dummy_l2_strtab(struct arm_smmu_device *smmu, u32 sid)
 	return __arm_smmu_init_l2_strtab(smmu, sid, &dummy_desc);
 }
 
-static __le64 *arm_smmu_get_step_for_sid(struct arm_smmu_device *smmu, u32 sid);
-
-static void arm_smmu_ste_abort_quirks(struct arm_smmu_device *smmu, u64 evt0)
-{
-	int i;
-	__le64 *dst, *src;
-	u64 val, paddr;
-	u32 sid = FIELD_GET(EVTQ_0_SID, evt0);
-	struct arm_smmu_strtab_cfg *cfg = &smmu->strtab_cfg;
-
-	/* SubStreamID is not support yet */
-	if (FIELD_GET(EVTQ_0_SSV, evt0))
-		return;
-
-	if (smmu->features & ARM_SMMU_FEAT_2_LVL_STRTAB) {
-		int idx, ret;
-
-		idx = (sid >> STRTAB_SPLIT) * STRTAB_L1_DESC_DWORDS;
-		if (!cfg->l1_desc[idx].l2ptr) {
-			ret = arm_smmu_init_l2_strtab(smmu, sid);
-			if (ret)
-				return;
-		}
-	}
-
-	dst = arm_smmu_get_step_for_sid(smmu, sid);
-	val = le64_to_cpu(dst[0]);
-	if (FIELD_GET(STRTAB_STE_0_CFG, val) != STRTAB_STE_0_CFG_ABORT)
-		return;
-
-	if (smmu->features & ARM_SMMU_FEAT_2_LVL_STRTAB) {
-		paddr = cfg->former_strtab_dma +
-			(sid >> STRTAB_SPLIT) * STRTAB_L1_DESC_SIZE;
-		src = ioremap(paddr, STRTAB_L1_DESC_SIZE);
-		if (!src)
-			return;
-
-		paddr = le64_to_cpu(*src) & STRTAB_L1_DESC_L2PTR_MASK;
-		iounmap(src);
-		paddr += (sid & ((1 << STRTAB_SPLIT) - 1)) * STRTAB_STE_SIZE;
-	} else {
-		paddr = cfg->former_strtab_dma + (sid * STRTAB_STE_SIZE);
-	}
-
-	src = ioremap(paddr, STRTAB_STE_SIZE);
-	if (!src)
-		return;
-
-	for (i = 1; i < STRTAB_STE_DWORDS; i++)
-		dst[i] = src[i];
-	arm_smmu_sync_ste_for_sid(smmu, sid);
-	dst[0] = src[0];
-	arm_smmu_sync_ste_for_sid(smmu, sid);
-	iounmap(src);
-}
-
 static struct arm_smmu_master_data *
 arm_smmu_find_master(struct arm_smmu_device *smmu, u32 sid)
 {
@@ -1595,8 +1534,6 @@ static irqreturn_t arm_smmu_evtq_thread(int irq, void *dev)
 				dev_info(smmu->dev, "\t0x%016llx\n",
 					 (unsigned long long)evt[i]);
 
-			if ((id == EVTQ_0_ID_C_BAD_STE) && is_kdump_kernel())
-				arm_smmu_ste_abort_quirks(smmu, evt[0]);
 		}
 
 		/*
@@ -3518,7 +3455,6 @@ static int arm_smmu_device_reset(struct arm_smmu_device *smmu, bool bypass)
 {
 	int ret;
 	u32 reg, enables;
-	u64 reg64;
 	struct arm_smmu_cmdq_ent cmd;
 
 	/* Clear CR0 and sync (disables SMMU and queue processing) */
@@ -3554,10 +3490,6 @@ static int arm_smmu_device_reset(struct arm_smmu_device *smmu, bool bypass)
 
 	writel_relaxed(reg, smmu->base + ARM_SMMU_CR2);
 
-	/* save the former strtab base */
-	reg64 = readq_relaxed(smmu->base + ARM_SMMU_STRTAB_BASE);
-	smmu->strtab_cfg.former_strtab_dma = reg64 & STRTAB_BASE_ADDR_MASK;
-
 	/* Stream table */
 	writeq_relaxed(smmu->strtab_cfg.strtab_base,
 		       smmu->base + ARM_SMMU_STRTAB_BASE);