From bcf0080873c74e9c81e6b27fc1bf0002ee6add9a Mon Sep 17 00:00:00 2001 From: John Garry Date: Wed, 2 Jan 2019 18:12:07 +0800 Subject: [PATCH] HISI LPC: Don't fail probe for unrecognised child devices mainline inclusion from next commit: category: bugfix bugzilla: 5498 CVE: NA ----------------------------------------- Currently for ACPI-based FW we fail the probe for an unrecognised child HID. However, there is FW in the field with LPC child devices having fake HIDs, namely "IPI0002", which was an IPMI device invented to support the origin LPC host driver, different from the final mainline version. To provide compatibility support for these dodgy FWs, just discard the unrecognised HIDs instead of failing the probe altogether. Signed-off-by: John Garry Signed-off-by: Yang Yingliang --- drivers/bus/hisi_lpc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c index d5f85455fa62..19d7b6ff2f17 100644 --- a/drivers/bus/hisi_lpc.c +++ b/drivers/bus/hisi_lpc.c @@ -522,10 +522,9 @@ static int hisi_lpc_acpi_probe(struct device *hostdev) if (!found) { dev_warn(hostdev, - "could not find cell for child device (%s)\n", + "could not find cell for child device (%s), discarding\n", hid); - ret = -ENODEV; - goto fail; + continue; } pdev = platform_device_alloc(cell->name, PLATFORM_DEVID_AUTO); -- GitLab