From b3f7a7b48f429e52f3d3dc36d253627c2a73803b Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Thu, 22 May 2014 10:53:06 +0300 Subject: [PATCH] ieee802154: missing put_dev() on error We should call put_dev() on the error path here. Fixes: 3e9c156e2c21 ('ieee802154: add netlink interfaces for llsec') Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller --- net/ieee802154/nl-mac.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/ieee802154/nl-mac.c b/net/ieee802154/nl-mac.c index 5617b4c6d6d5..a3281b8bfd5b 100644 --- a/net/ieee802154/nl-mac.c +++ b/net/ieee802154/nl-mac.c @@ -832,8 +832,10 @@ int ieee802154_llsec_getparams(struct sk_buff *skb, struct genl_info *info) return -ENODEV; ops = ieee802154_mlme_ops(dev); - if (!ops->llsec) - return -EOPNOTSUPP; + if (!ops->llsec) { + rc = -EOPNOTSUPP; + goto out_dev; + } msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); if (!msg) -- GitLab